XER10-2713: [XER10]QOS rules are not cleared after Factory Reset#268
XER10-2713: [XER10]QOS rules are not cleared after Factory Reset#268Jayashree-malaivasan wants to merge 4 commits intodevelopfrom
Conversation
Reason for change: Remove prioratization files on factory reset Test Procedure: Check the Qos rules are removed on FR Priority: P1 Signed-off-by: Jayashree <jayashree_M@comcast.com>
There was a problem hiding this comment.
Pull request overview
Removes persisted QoS prioritization artifacts during factory reset so that QoS rules don’t survive a Factory Reset, aligning runtime behavior with expected “clean slate” resets.
Changes:
- On factory reset, delete
/nvram/pcs-now-priomac.datand its.md5file.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Reason for change: Remove prioratization files on factory reset Test Procedure: Check the Qos rules are removed on FR Priority: P1 Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the factory reset cleanup logic to ensure QoS prioritization artifacts are removed, addressing cases where QoS rules persist after a factory reset.
Changes:
- Remove
/nvram/pcs-now-priomac.datand its.md5during factory reset in the mainutopia_init.shinit path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Reason for change: Remove prioratization files on factory reset Test Procedure: Check the Qos rules are removed on FR Priority: P1 Signed-off-by: Jayashree <jayashree_M@comcast.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses XER10-2713 by ensuring prioritized QoS schedule artifacts are cleared during factory reset, preventing QoS rules from persisting after FR.
Changes:
- Delete
/nvram/pcs-now-priomac.daton factory reset. - Delete
/nvram/pcs-now-priomac.dat.md5on factory reset.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
apattu200
left a comment
apattu200
left a comment
There was a problem hiding this comment.
Add check to make sure file exists before removal
Reason for change: Remove prioratization files on factory reset Test Procedure: Check the Qos rules are removed on FR Priority: P1 Signed-off-by: Jayashree jayashree_M@comcast.com
There was a problem hiding this comment.
Pull request overview
This PR addresses XER10-2713 by ensuring prioritized QoS schedule artifacts are cleared during factory reset, preventing stale QoS rules from persisting after FR.
Changes:
- Delete
/nvram/pcs-now-priomac.datand/nvram/pcs-now-priomac.dat.md5during the factory reset flow in the mainutopia_init.sh.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| # Remove on factory reset, prioritized QoS schedule pcs-now-priomac.dat and pcs-now-priomac.dat.md5 | ||
| rm -f /nvram/pcs-now-priomac.dat | ||
| rm -f /nvram/pcs-now-priomac.dat.md5 | ||
| fi | ||
|
|
Reason for change: Remove prioratization files on factory reset
Test Procedure: Check the Qos rules are removed on FR
Priority: P1
Signed-off-by: Jayashree jayashree_M@comcast.com