RDKB-63098: [ONESTACK]-Handle IPv6 delegation for business vs residential#270
Open
RDKB-63098: [ONESTACK]-Handle IPv6 delegation for business vs residential#270
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates IPv6 firewall rule generation to better handle prefix delegation behavior differences between OneStack business vs residential modes, focusing on WAN→LAN forwarding behavior for delegated prefixes.
Changes:
- Gates prefix-delegation forward rules on
FEATURE_IPV6_DELEGATIONsupport in the current mode. - Removes unconditional WAN→LAN ACCEPT behavior for delegated prefixes when IPv6 firewall level isn’t
Custom, relying instead on the standardwan2lanpolicy path. - Adds a conditional
wan2lanrule to accept established WAN→LAN traffic when IPv6 delegation is enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: WAN to LAN Firewall rules
Test Procedure:
Build OneStack Image
In Business-mode, Check dibbler server is started and server.conf has prefix-delegation class
In Residential-mode, check whether device behaves as a non-CBR device Risks: None
Priority: P1
Is this a User Story (US)?
Have all dependent PRs from other components been listed ?
Does the commit message include both the User Story ticket and the Subtask ticket?
Will be all changes related to the User Story squashed and merged in a single commit?
Has the PR been raised only after completing all changes for the User Story (no partial changes)?
Has code development for the User Story been completed?
If yes, has the Gerrit topic or list of all dependent PRs across components (including meta-layer changes) been shared?
https://gerrit.teamccp.com/#/c/946157/
Is there a validation log available in the Jira ticket for verifying builds with the updated generic-srcrev.inc across all platforms?