RDKB-62863: WiFi ready page is missing in captive portal#105
Merged
GoutamD2905 merged 1 commit intodevelopfrom Mar 3, 2026
Merged
RDKB-62863: WiFi ready page is missing in captive portal#105GoutamD2905 merged 1 commit intodevelopfrom
GoutamD2905 merged 1 commit intodevelopfrom
Conversation
Reason for change: WiFi ready page is missing in captive portal after a Factory reset in 8.2x Test Procedure: Test for captive portal Risks:low Priority: P1 Signed-off-by: pavankumarreddy_balireddy@comcast.com
There was a problem hiding this comment.
Pull request overview
This PR addresses a bug where the WiFi ready page was not displaying in the captive portal after a factory reset. The fix relocates the setTimeout call that triggers the ready page display from inside the AJAX success callback to immediately after the saveConfig() function initiates the AJAX request.
Changes:
- Moved setTimeout call for goToReady() from AJAX success callback to execute immediately after postConfig() is called for non-WiFi connections
- Timer now starts when configuration save begins rather than after successful completion
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GoutamD2905
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: WiFi ready page is missing in captive portal after a Factory reset in 8.2x
Test Procedure: Test for captive portal
Risks:low
Priority: P1
Signed-off-by: pavankumarreddy_balireddy@comcast.com