RDKEMW-5849 : remove deprecated "experience" code

[jthomp007c]

Reason for change: the app controls experience, ctrlm does is no longer involved

Test Procedure: nothing new to test. Check that normal functionality is not affected

Priority: P2

[Copilot]

Pull request overview

Removes deprecated “experience” plumbing from the VREX websocket-nextgen and HTTP request paths, reflecting that the app now owns the experience concept.

Changes:

• Dropped experience fields from request parameter structs and removed the associated update APIs.
• Removed propagation of experience into NextGen JSON payloads and HTTP query strings.
• Reduced the router’s maximum supported query-string count constant.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/xr-speech-vrex/xrsv_ws_nextgen/xrsv_ws_nextgen.h	Removes experience param and update API from the NextGen websocket interface.
src/xr-speech-vrex/xrsv_ws_nextgen/xrsv_ws_nextgen.c	Stops emitting experience in NextGen JSON init payload; removes update helper.
src/xr-speech-vrex/xrsv_http/xrsv_http.h	Removes experience param and update API from the HTTP interface.
src/xr-speech-vrex/xrsv_http/xrsv_http.c	Removes experienceTag query element handling and reindexes query string list.
src/xr-speech-router/xrsr.h	Lowers the max supported count of query strings.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[egalla204]

approved for test

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (2)

src/xr-speech-vrex/xrsv_ws_nextgen/xrsv_ws_nextgen.h:83

• This header is installed as part of the public SDK (see src/CMakeLists.txt install rules). Removing experience from xrsv_ws_nextgen_params_t is an API/ABI breaking change for external consumers that compile against this header. If the intent is to drop deprecated API, ensure versioning/SONAME and release notes reflect this; otherwise consider keeping the field (ignored/no-op) until the next major release.

/// @details The param data structure is used to provide input parameters to the xrsv_ws_nextgen_open() function.  All string parameters must be NULL-terminated.  If a string parameter is not present, NULL must be set for it.
typedef struct {
   const char *device_id;                 ///< The client device's unique identifier
   const char *account_id;                ///< The user's account identifier
   const char *partner_id;                ///< The network's partner identifier
   const char *audio_profile;             ///< Device audio profile
   const char *audio_model;               ///< Device audio model
   const char *language;                  ///< The device's language
   const char *device_mac;                ///< The device's MAC address
   const char *rf_protocol;               ///< The device's RF protocol

src/xr-speech-vrex/xrsv_ws_nextgen/xrsv_ws_nextgen.h:355

• This header is installed as part of the public SDK (see src/CMakeLists.txt install rules). Removing xrsv_ws_nextgen_update_experience() is a breaking public API change for any downstream users. If this removal is intended as part of a deprecation plan, ensure the library major version / SONAME is updated accordingly; otherwise consider leaving a deprecated no-op wrapper for one release cycle to ease migrations.

/// @brief Update the vrex speech request handler's partner id
/// @details Function used to update the partner identifier.
/// @param[in] partner_id Network's partner identifier stored as a NULL-terminated string
/// @return The function returns true for success, otherwise false.
bool xrsv_ws_nextgen_update_partner_id(xrsv_ws_nextgen_object_t object, const char *partner_id);

/// @brief Update the vrex speech request handler's audio profile
/// @details Function used to update the device's audio profile.
/// @param[in] audio_profile Audio profile name stored as a NULL-terminated string
/// @return The function returns true for success, otherwise false.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[egalla204]

approved for test