-
-
Notifications
You must be signed in to change notification settings - Fork 1
Fix split-pane side menu gap on smaller viewports #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for ionic-theme-ios26 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: rdlabo <9690024+rdlabo@users.noreply.github.com>
Co-authored-by: rdlabo <9690024+rdlabo@users.noreply.github.com>
Co-authored-by: rdlabo <9690024+rdlabo@users.noreply.github.com>
Playwright test resultsDetails
Failed testschromium › screenshot.spec.ts › Screenshot Tests - All Routes › should match screenshot for button |
|
/update-screenshots |
|
📊 Playwright Test Report View the detailed test report: https://rdlabo-team.github.io/ionic-theme-ios26/pr-90/ |
|
✅ Screenshots have been updated successfully! The new screenshots have been committed to this PR. |
On smaller viewports,
ion-split-paneshrinks the menu to 28% width (Ionic default) while content padding remains fixed at 360px, creating a gap.Changes
--side-max-widthwith--ios26-menu-widthonion-split-paneto maintain consistent widthBefore
After
1024px viewport:

992px viewport:

Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www.google-analytics.com/usr/local/bin/node node /home/REDACTED/work/ionic-theme-ios26/ionic-theme-ios26/demo/node_modules/.bin/ng build --configuration=production(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.