build(deps): bump django to 5.2 lts #1457

afuetterer · 2025-10-28T11:56:20Z

Description

Related issue: #742

Ref: https://docs.djangoproject.com/en/5.2/releases/5.2/

Tasks

bump django to 5.2.8, when that is released https://docs.djangoproject.com/en/5.2/releases/5.2.8/
remove changes to pytest deps (will get bumps from dependency update branch after rebase)
ruff step in pre-commit.ci fails, due to newer ruff version, will get fixed after rebase of 2.3.3 branch
tests against 3.10 and 3.13 in CI (will get included after rebase of 2.4.0 branch)
remove TODOs
remove changes to pre-commit config
discuss usage of error on RemovedInNextVersionWarning (future proofing)
squash commits
add note to changelog / release notes: Django 5.2 supports PostgreSQL 14 and higher. -> will be done later by @jochenklar

How has this been tested?

I created a PR in my fork, which successfully completed.

afuetterer · 2025-10-28T12:13:38Z

I ran django-upgrade (with target version 5.2) to check for any possible upgrades. I included those here, e.g. path vs re_path, HTTP_REFERER vs referer. Is that alright or should that be an extra PR? It is not mandatory to upgrade those files.

What do you think?

jochenklar · 2025-10-28T12:20:56Z

Nope, not for RDMO.

afuetterer · 2025-10-28T12:49:03Z

Anything else interesting in the list of changes?
https://docs.djangoproject.com/en/5.0/releases/5.0/
https://docs.djangoproject.com/en/5.1/releases/5.1/
https://docs.djangoproject.com/en/5.2/releases/5.2/

MyPyDavid · 2026-01-08T14:27:18Z

we will try this for the 2.5.0 release, @jochenklar

MyPyDavid · 2026-01-08T20:36:55Z

Can I rebase to 2.5.0?

yes exactly, thanks! I've just changed the target branch to the 2.5.0/release and it looks already good in this PR right (only 4 commits)? You also want to continue with the implementations in this PR?

afuetterer · 2026-01-09T08:51:44Z

Rebased to 2.5.0/release branch.

afuetterer · 2026-01-09T08:53:42Z

I removed upgrades done with django-upgrade. This can be added later.

pyproject.toml

afuetterer · 2026-01-09T08:56:08Z

testing/config/settings/base.py

 PROJECT_CONTACT = True
 PROJECT_CONTACT_RECIPIENTS = ['email@example.com']
+
+# Ref: https://adamj.eu/tech/2023/12/07/django-fix-urlfield-assume-scheme-warnings


I followed the writeup available at: https://adamj.eu/tech/2023/12/07/django-fix-urlfield-assume-scheme-warnings

So there is a warning we need to suppress, even if we set it explicitly? This is a bit weird.

It seems so, sorry. If you remove this "hack", you get an error.

afuetterer · 2026-01-09T11:36:33Z

CI passed for 3.10 and 3.13, yay. Anybody wants to test on their servers with real world data?

jochenklar · 2026-01-09T14:07:05Z

With 3.14 it almost works.

index 2c446d519..c9bcfee38 100644
--- a/rdmo/core/tests/test_utils.py
+++ b/rdmo/core/tests/test_utils.py
@@ -42,7 +42,7 @@ valid_date_strings = [
 ]

 invalid_date_strings = [
-    ("2025-02-31","day is out of range for month"),
+    ("2025-02-31","day 31 must be in range 1..28 for month 2 in year 2025"),
     ("2025-17-02", "month must be in 1..12"),
     ("99/99/9999", "Invalid date format"),
     ("abcd-ef-gh", "Invalid date format"),

I think @MyPyDavid added this test. Maybe we just get rid of the test for the string instead of checking for python versions.

afuetterer · 2026-01-09T14:35:20Z

According to the discussion in #742, I did not include 3.14 in this PR.

jochenklar · 2026-01-09T14:39:13Z

Alright, got it.

afuetterer · 2026-01-12T07:11:13Z

What else needs to be addressed in this PR? Otherwise I will set it to ready for review, after squashing the commits.

MyPyDavid · 2026-01-16T13:23:29Z

I checked it out and it looks good to me.
I've added now the fix for this failing test in python 3.14 (also didn't know that we are supporting that version :p)

I would approve it like this as well, you don't need to squash commits necessarily!

afuetterer · 2026-01-16T13:46:18Z

I have commits with stupid messages dangling in this branch like "settings" and "warnings". Will clean that up.

How about the changelog stuff? Will this be done when finishing the release?

As I stated in the PR description this change would require admins to e.g. bump postgres to >= 14.

Upstream support for PostgreSQL 13 ends in November 2025. Django 5.2 supports PostgreSQL 14 and higher.
Ref: https://docs.djangoproject.com/en/5.2/releases/5.2/#dropped-support-for-postgresql-13

Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>

jochenklar · 2026-01-16T14:24:57Z

Good point. I usually write the CHANGELOG in the end, to avoid merging/rebasing the file all the time. I will put it in my notes.

afuetterer · 2026-01-16T14:49:20Z

Good point. I usually write the CHANGELOG in the end, to avoid merging/rebasing the file all the time. I will put it in my notes.

Excellent, as I said earlier, these are the django changelogs when bumping 4.2 to 5.2.

jochenklar

Awesome thanks!

MyPyDavid

thank you 🙏 for 5.2!

afuetterer · 2026-01-16T18:12:37Z

Permission to merge?

afuetterer · 2026-01-21T08:30:19Z

I don't want to interfere with your planning of 2.5.0. Can this be merged now or should features come first?

jochenklar · 2026-01-21T09:23:26Z

Sorry, please merge!

afuetterer added type:maintenance dependencies Pull requests that update a dependency file labels Oct 28, 2025

afuetterer marked this pull request as draft October 28, 2025 11:56

This comment was marked as resolved.

Sign in to view

afuetterer added this to the RDMO 3.0.0 milestone Oct 28, 2025

afuetterer linked an issue Oct 28, 2025 that may be closed by this pull request

Update Django to Version 5.2 LTS #742

Open

afuetterer force-pushed the 742-django-5.2 branch from e8c68be to 16f7b8b Compare October 28, 2025 12:59

afuetterer force-pushed the 742-django-5.2 branch 2 times, most recently from 6c6f9e3 to f4c7c9d Compare November 7, 2025 12:05

afuetterer force-pushed the 742-django-5.2 branch from f4c7c9d to 7a227c5 Compare December 17, 2025 13:22

This comment was marked as resolved.

Sign in to view

MyPyDavid self-assigned this Jan 8, 2026

MyPyDavid modified the milestones: RDMO 3.0.0, RDMO 2.5.0 Jan 8, 2026

This comment was marked as resolved.

Sign in to view

MyPyDavid changed the base branch from 3.0.0 to 2.5.0/release January 8, 2026 20:33

afuetterer force-pushed the 742-django-5.2 branch 2 times, most recently from d4bae55 to 57c17ab Compare January 9, 2026 08:51

afuetterer commented Jan 9, 2026

View reviewed changes

pyproject.toml Show resolved Hide resolved

afuetterer commented Jan 9, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

afuetterer and others added 2 commits January 16, 2026 15:23

build(deps): bump django to >= 5.2.8

a171e80

tests: make utils parse date test compatible with python 3.14

ab36c2f

Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>

afuetterer force-pushed the 742-django-5.2 branch from 6e100f2 to ab36c2f Compare January 16, 2026 14:24

afuetterer marked this pull request as ready for review January 16, 2026 14:24

afuetterer mentioned this pull request Jan 16, 2026

Add support for Python 3.14 #1469

Open

afuetterer requested review from MyPyDavid and jochenklar January 16, 2026 15:15

jochenklar approved these changes Jan 16, 2026

View reviewed changes

MyPyDavid approved these changes Jan 16, 2026

View reviewed changes

afuetterer merged commit be74ad6 into rdmorganiser:2.5.0/release Jan 21, 2026
18 checks passed

afuetterer deleted the 742-django-5.2 branch January 21, 2026 11:57

build(deps): bump django to 5.2 lts #1457

build(deps): bump django to 5.2 lts #1457

Uh oh!

Conversation

afuetterer commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Tasks

How has this been tested?

Uh oh!

afuetterer commented Oct 28, 2025

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

jochenklar commented Oct 28, 2025

Uh oh!

afuetterer commented Oct 28, 2025

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

MyPyDavid commented Jan 8, 2026

Uh oh!

This comment was marked as resolved.

MyPyDavid commented Jan 8, 2026

Uh oh!

afuetterer commented Jan 9, 2026

Uh oh!

afuetterer commented Jan 9, 2026

Uh oh!

Uh oh!

afuetterer Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

jochenklar Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

afuetterer Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

afuetterer commented Jan 9, 2026

Uh oh!

jochenklar commented Jan 9, 2026

Uh oh!

afuetterer commented Jan 9, 2026

Uh oh!

jochenklar commented Jan 9, 2026

Uh oh!

afuetterer commented Jan 12, 2026

Uh oh!

MyPyDavid commented Jan 16, 2026

Uh oh!

afuetterer commented Jan 16, 2026

Uh oh!

jochenklar commented Jan 16, 2026

Uh oh!

afuetterer commented Jan 16, 2026

Uh oh!

jochenklar left a comment

Choose a reason for hiding this comment

Uh oh!

MyPyDavid left a comment

Choose a reason for hiding this comment

Uh oh!

afuetterer commented Jan 16, 2026

Uh oh!

afuetterer commented Jan 21, 2026

Uh oh!

jochenklar commented Jan 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

afuetterer commented Oct 28, 2025 •

edited

Loading