Skip to content

fix: ipallowlists:exception on getBindingDetails #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rdurbalauadb wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: ipallowlists:exception on getBindingDetails #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54253c7
Update get-binding-details.js
rdurbalauadb Feb 21, 2025
ec8c134
Update tests for get-binding-details.test.js
rdurbalauadb Feb 21, 2025
a7248a5
Update get-binding-details.test.js
rdurbalauadb Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commands/cloudmanager/ip-allowlist/get-binding-details.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class ListIPAllowlistBindingDetails extends BaseCommand {

const result = await this.listIpAllowlists(programId, flags.imsContextName)

const allowList = result.find(allowList => allowList.id === args.ipAllowlistId)
const allowList = result.find(allowList => allowList.id === Number(args.ipAllowlistId))

if (!allowList) {
throw new validationCodes.IP_ALLOWLIST_NOT_FOUND({ messageValues: [args.ipAllowlistId, programId] })
Expand Down
18 changes: 9 additions & 9 deletions test/commands/ip-allowlist/get-binding-details.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ test('get-binding-details - not found', async () => {

mockSdk.listIpAllowlists = jest.fn(() => Promise.resolve([
{
id: '1',
id: 1,
name: 'test1',
ipCidrSet: ['1.1.1.1/5', '2.2.2.2/5'],
programId: '4',
Expand All @@ -55,7 +55,7 @@ test('get-binding-details - no bindings', async () => {

mockSdk.listIpAllowlists = jest.fn(() => Promise.resolve([
{
id: '1',
id: 1,
name: 'test1',
ipCidrSet: ['1.1.1.1/5', '2.2.2.2/5'],
programId: '4',
Expand All @@ -66,7 +66,7 @@ test('get-binding-details - no bindings', async () => {
const runResult = ListIPAllowlistBindingDetails.run(['--programId', '4', '1'])
await expect(runResult instanceof Promise).toBeTruthy()
await expect(runResult).resolves.toMatchObject({
id: '1',
id: 1,
bindings: [],
})
await expect(mockSdk.listIpAllowlists.mock.calls.length).toEqual(1)
Expand All @@ -84,7 +84,7 @@ test('get-binding-details - normal with bindings', async () => {

mockSdk.listIpAllowlists = jest.fn(() => Promise.resolve([
{
id: '1',
id: 1,
name: 'test1',
ipCidrSet: ['1.1.1.1/5', '2.2.2.2/5'],
programId: '4',
Expand All @@ -98,7 +98,7 @@ test('get-binding-details - normal with bindings', async () => {
const runResult = ListIPAllowlistBindingDetails.run(['--programId', '4', '1'])
await expect(runResult instanceof Promise).toBeTruthy()
await expect(runResult).resolves.toMatchObject({
id: '1',
id: 1,
bindings: [{
environmentId: '3',
environmentName: 'TestProgram_dev',
Expand All @@ -114,7 +114,7 @@ test('get-binding-details - binding to unknown environment (should not ever happ

mockSdk.listIpAllowlists = jest.fn(() => Promise.resolve([
{
id: '1',
id: 1,
name: 'test1',
ipCidrSet: ['1.1.1.1/5', '2.2.2.2/5'],
programId: '4',
Expand All @@ -128,7 +128,7 @@ test('get-binding-details - binding to unknown environment (should not ever happ
const runResult = ListIPAllowlistBindingDetails.run(['--programId', '4', '1'])
await expect(runResult instanceof Promise).toBeTruthy()
await expect(runResult).resolves.toMatchObject({
id: '1',
id: 1,
bindings: [{
environmentId: 'X',
environmentName: 'Environment X',
Expand All @@ -144,7 +144,7 @@ test('get-binding-details - bindings when environment load fails', async () => {

mockSdk.listIpAllowlists = jest.fn(() => Promise.resolve([
{
id: '1',
id: 1,
name: 'test1',
ipCidrSet: ['1.1.1.1/5', '2.2.2.2/5'],
programId: '4',
Expand All @@ -159,7 +159,7 @@ test('get-binding-details - bindings when environment load fails', async () => {
const runResult = ListIPAllowlistBindingDetails.run(['--programId', '4', '1'])
await expect(runResult instanceof Promise).toBeTruthy()
await expect(runResult).resolves.toMatchObject({
id: '1',
id: 1,
bindings: [{
environmentId: 'X',
environmentName: 'Environment X',
Expand Down