Skip to content

Commit 00b07f5

Browse files
committed
adjust notifications
1 parent 4fa5a8e commit 00b07f5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/superset/services/dashboard_report.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,15 @@ def data_sovereignty_issues
4747
reasons = []
4848
chart_dataset_ids = dashboard[:datasets][:chart_datasets].map{|d| d[:id]}
4949

50-
# invalid if any filters datasets are not part of the chart datasets
50+
# add WARNING msg if any filters datasets are not part of the chart datasets
5151
unknown_datasets = dashboard[:filters][:filter_dataset_ids] - chart_dataset_ids
5252
if unknown_datasets.any?
5353
reasons << "WARNING: One or more filter datasets is not included in chart datasets for " \
5454
"filter dataset ids: #{unknown_datasets.join(', ')}."
5555
reasons << "DETAILS: #{unknown_dataset_details(unknown_datasets)}"
5656
end
5757

58-
# invalid if any filters datasets are not part of the chart datasets
58+
# add ERROR msg if multiple chart dataset schemas are found
5959
chart_dataset_schemas = dashboard[:datasets][:chart_datasets].map{|d| d[:schema]}.uniq
6060
if chart_dataset_schemas.count > 1
6161
reasons << "ERROR: Multiple distinct chart dataset schemas found. Expected 1. Found #{chart_dataset_schemas.count}. " \

0 commit comments

Comments
 (0)