[NEP-18619]: Rspec fixes

Author: soundarya-mv

spec/superset/dashboard/datasets/list_spec.rb

@@ -1,8 +1,9 @@
 require 'spec_helper'
 
 RSpec.describe Superset::Dashboard::Datasets::List do
-  subject { described_class.new(dashboard_id) }
+  subject { described_class.new(dashboard_id: dashboard_id, include_filter_datasets: include_filter_datasets) }
   let(:dashboard_id) { 1 }
+  let(:include_filter_datasets) { false }
   let(:result) do
     [
       {
@@ -64,6 +65,46 @@
         {"id"=>102, "datasource_name"=>"video_game_sales", "schema"=>"public", "database"=>{"id"=>2, "name"=>"examples", "backend"=>"postgres"}, "sql"=>"select * from acme_new.forecasts"}
       ])
     end
+
+    context 'returns both chart and filter datasets when include_filter_datasets is true' do
+      before do
+        allow(subject).to receive(:filter_dataset_ids).and_return([103,104])
+        allow(subject).to receive(:filter_datasets).with([103,104]).and_return(filter_dataset_json)
+      end
+      let(:include_filter_datasets) { true }
+      let(:filter_dataset_json) {
+      [
+        {
+          "id"=>103, 
+          "datasource_name"=>"Filter 1", 
+          "schema"=>"acme", 
+          "database"=>{
+            "id"=>1, 
+            "name"=>"DB1", 
+            "backend"=>"postgres"
+          }, 
+          "sql"=>"select * from acme.forecasts"
+        },
+        {
+          "id"=>104, 
+          "datasource_name"=>"Filter 2", 
+          "schema"=>"public",
+          "database"=>{
+            "id"=>2, 
+            "name"=>"examples", 
+            "backend"=>"postgres"
+          }, 
+          "sql"=>"select * from acme_new.forecasts"
+        }
+      ]
+      }
+      specify do
+        expect(subject.datasets_details).to eq([
+          {"id"=>101, "datasource_name"=>"Acme Forecasts", "schema"=>"acme", "database"=>{"id"=>1, "name"=>"DB1", "backend"=>"postgres"}, "sql"=>"select * from acme.forecasts"},
+          {"id"=>102, "datasource_name"=>"video_game_sales", "schema"=>"public", "database"=>{"id"=>2, "name"=>"examples", "backend"=>"postgres"}, "sql"=>"select * from acme_new.forecasts"}
+        ] + filter_dataset_json)
+      end
+    end
   end
 
   describe '#table' do

spec/superset/dashboard/get_spec.rb

@@ -12,7 +12,7 @@
       'published' => true,
       'changed_on_delta_humanized' => '1 day ago',
       'charts' => dashboard_charts,
-      'json_metadata' => { 'key1' => 'value1' }.to_json,
+      'json_metadata' => { 'native_filter_configuration' => [] }.to_json,
       'position_json' => { 'key2' => 'value2' }.to_json,
       'url' => '',
 
@@ -43,6 +43,12 @@
     end
   end
 
+  describe '#filter_configuration' do
+    it 'returns the filter_configuration' do
+      expect(subject.filter_configuration).to eq(JSON.parse(dashboard_result['json_metadata'])['native_filter_configuration'])
+    end
+  end
+
   describe '#positions' do
     it 'returns the parsed positions' do
       expect(subject.positions).to eq(JSON.parse(dashboard_result['position_json']))