Skip to content

Commit ba0569b

Browse files
committed
[NEP-18619]: Addressing review comments
1 parent 13ead7d commit ba0569b

File tree

1 file changed

+2
-1
lines changed
  • lib/superset/dashboard/datasets

1 file changed

+2
-1
lines changed

lib/superset/dashboard/datasets/list.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ def datasets_details
4444
chart_dataset_ids = chart_datasets.map{|d| d['id'] }
4545
filter_dataset_ids_not_used_in_charts = filter_dataset_ids - chart_dataset_ids
4646
return chart_datasets if filter_dataset_ids_not_used_in_charts.empty?
47-
dashboard_datasets = chart_datasets + filter_datasets(filter_dataset_ids_not_used_in_charts)
47+
# returning chart and filter datasets
48+
chart_datasets + filter_datasets(filter_dataset_ids_not_used_in_charts)
4849
end
4950

5051
private

0 commit comments

Comments
 (0)