Skip to content

[NEP-19227] remove catalog attrib from datasets #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[NEP-19227] remove catalog attrib from datasets #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/superset/services/import_dashboard_across_environment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@
must already exist as a database connection in the target superset environment.

Currently handles only 1 Database yaml file in the zip file. ( ie only 1 common database connection per dashboards datasets )
Targeted towards Dashboard for an individual Clients Database Data only.
Most often used in EXTERNAL facing embedded client dashboards.

Required Attributes:
Required Attributes:
- target_database_yaml_file - location of the target database yaml config file
- target_database_schema - the schema name to be used in the target database
- dashboard_export_zip - location of the source dashboard export zip file to tranferred to a new superset Env
Expand Down Expand Up @@ -78,6 +80,9 @@ def update_dataset_configs
dashboard_config[:datasets].each do |dataset|
dataset[:content][:database_uuid] = dashboard_config[:databases].first[:content][:uuid]
dataset[:content][:schema] = target_database_schema

dataset[:content].delete(:catalog) # temp fix for catalog config issue. see NEP-19227. Unclear if we need to merge this yet.

stringified_content = deep_transform_keys_to_strings(dataset[:content])
File.open(dataset[:filename], 'w') { |f| f.write stringified_content.to_yaml }
end
Expand All @@ -103,7 +108,7 @@ def new_database_yaml_file_path

def dashboard_export_root_path
# locate the unziped dashboard_export_* directory as named by superset app, eg dashboard_export_20240821T001536
@dashboard_export_root_path ||= begin
@dashboard_export_root_path ||= begin
pattern = File.join(dashboard_config[:tmp_uniq_dashboard_path], 'dashboard_export_*')
Dir.glob(pattern).first
end
Expand Down