RMLNQFETCH-19 Support for .net standard #1
Conversation
ngbrown
changed the title
There was a problem hiding this comment.
Looks good :) Thanks for the work!
I did find a couple of bits that weren't obivous to anyone not deep into this particular setup and pushed them into https://github.com/re-motion/Relinq-EagerFetching/commits/feature/RMLNQFETCH-19-Support-For-NetStandard. If you want, feel free to go head and rewrite the PR to integrate my updates to your commits :)
I've also uploaded a nightly build of the .NET Standard enabled package: https://www.re-motion.org/jira/secure/attachment/12900/Remotion.Linq.EagerFetching.2.1.0-x-001-25.nupkg
It would be great if you could give it a whirl to make sure everything works with .NET Standard. (I don't have a test setup for that ATM.) I'll do the release after that one.
ngbrown
force-pushed
the
feature/RMLNQFETCH-19-Support-For-NetStandard
branch
from
9db7a46 to
6bd792d
Compare
|
@MichaelKetting I did re-write your improvements into my pull request. I've also used your attachment in a NHibernate pull request (nhibernate/nhibernate-core#633) and it seems to be working well enough. Any chance you could publish the NuGet package on a feed of some sort, even if only as an alpha or beta? |
|
@ngbrown Thanks. I've published a beta-release on nuget.org. |
|
@MichaelKetting can this be released as a release version? |
|
Yes, hopefully. Mainly, I was waiting for feedback on the beta, but now I found an issue last week, too. (https://www.re-motion.org/jira/browse/RMLNQFETCH-20) |
|
Actually, the same happens with ReLinq itself
…On Mon, 19 Jun 2017 at 6:07 PM, Michael Ketting ***@***.***> wrote:
Yes, hopefully. Mainly, I was waiting for feedback on the beta, but now I
found an issue last week, too. (
https://www.re-motion.org/jira/browse/RMLNQFETCH-20)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI1l_x8O_suwN8ZsYA4gqOhpCphYusuks5sFhAugaJpZM4NeYYY>
.
|
|
Yes, it does. The guys at PostSharp found that one (https://www.re-motion.org/jira/browse/RMLNQ-113) |
| <package id="NUnit" version="2.6.3" targetFramework="net40" /> | ||
| <package id="Remotion.Development.UnitTesting.PrivateInvoke.Sources" version="1.15.23.0" targetFramework="net45" developmentDependency="true" /> | ||
| <package id="Remotion.JetBrains.Annotations.Sources" version="1.15.23.0" targetFramework="net40" developmentDependency="true" /> | ||
| <package id="Remotion.Linq" version="2.0.0" targetFramework="net40" /> |
| <package id="Remotion.Development.UnitTesting.PrivateInvoke.Sources" version="1.15.23.0" targetFramework="net45" developmentDependency="true" /> | ||
| <package id="Remotion.JetBrains.Annotations.Sources" version="1.15.23.0" targetFramework="net40" developmentDependency="true" /> | ||
| <package id="Remotion.Linq" version="2.0.0" targetFramework="net40" /> | ||
| <package id="Remotion.Linq.Development" version="2.0.0" targetFramework="net40" /> |
| <?xml version="1.0" encoding="utf-8"?> | ||
| <packages> | ||
| <package id="Remotion.JetBrains.Annotations.Sources" version="1.15.23.0" targetFramework="portable-net45+win+wpa81+wp80" developmentDependency="true" /> | ||
| <package id="Remotion.Linq" version="2.0.0" targetFramework="net40-Client" /> |
|
@hazzik |
|
@MichaelKetting thanks. I've tested it, all looks good: nhibernate/nhibernate-core@b6c2e28 Also, RMLNQFETCH-21 shall be closed now |
|
@hazzik Great, thanks. RTM version is out now. |
3 participants
Pull request for RMLNQFETCH-19.