Skip to content

api key management#42

Merged
reVrost merged 2 commits intoreVrost:mainfrom
coalaura:api-keys
Jan 26, 2026
Merged

api key management#42
reVrost merged 2 commits intoreVrost:mainfrom
coalaura:api-keys

Conversation

@coalaura
Copy link
Contributor

Copy link
Owner

@reVrost reVrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @coalaura, just minor comments 🙂

require.NotEmpty(t, models[0].ID)
}

func TestGetCurrentAPIKey(t *testing.T) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add more tests around (ListAPIKeys, CreateAPIKey, GetAPIKey, UpdateAPIKey, DeleteAPIKey) perhaps including error cases and handling of optional fields.

Copy link
Contributor Author

@coalaura coalaura Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left those out for now since they require a provisioning api key rather than a normal api key, the show current key one is the only one that works on its own with a normal key

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plus create/update/delete would create keys in the tester's account so not sure, up to you i can add them

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah thats fair enough, no need for now thanks!

Copy link
Owner

@reVrost reVrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

require.NotEmpty(t, models[0].ID)
}

func TestGetCurrentAPIKey(t *testing.T) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah thats fair enough, no need for now thanks!

@reVrost reVrost merged commit 1fda6bb into reVrost:main Jan 26, 2026
1 check passed
@coalaura coalaura deleted the api-keys branch February 13, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants