Skip to content

fix(options-list): made menu options accessible #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(options-list): made menu options accessible #432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/OptionList/List.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,8 @@ const RawOptionList = React.forwardRef<RefOptionListProps, RawOptionListProps>((
);
});

const messages = activeValueCells.join(" / ")

Check notice

Code scanning / CodeQL

Semicolon insertion

Avoid automated semicolon insertion (96% of all statements in [the enclosing function](1) have an explicit semicolon).

// >>>>> Render
return (
<CacheContent open={open}>
Expand All @@ -234,6 +236,22 @@ const RawOptionList = React.forwardRef<RefOptionListProps, RawOptionListProps>((
>
{columnNodes}
</div>
<div
aria-live="polite"
style={{
zIndex: 9999,
border: 0,
clip: 'rect(1px, 1px, 1px, 1px)',
height: 1,
width: 1,
position: 'absolute',
overflow: 'hidden',
padding: 0,
whiteSpace: 'nowrap',
}}
>
{messages}
</div>
</CacheContent>
);
});
Expand Down