-
-
Notifications
You must be signed in to change notification settings - Fork 145
feat: retire deprecated api and rename to popup #558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5851494
refactor: update prop names and remove deprecated props
aojunhao123 4807756
chore: adjust logic
aojunhao123 38d47b4
Merge branch 'master' into retire-api
aojunhao123 f76b4ec
chore: remove useless code
aojunhao123 f569369
refactor: rename to popup
aojunhao123 d3e31df
chore: change import path
aojunhao123 ced37ee
chore: remove useless test case
aojunhao123 5858fb8
chore: remove compatible logic
aojunhao123 39a61a8
revert
aojunhao123 c911ae5
revert
aojunhao123 96b19ee
refactor: update key logic
aojunhao123 f442210
fix: type error
aojunhao123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| title: popup-render | ||
| nav: | ||
| title: Demo | ||
| path: /demo | ||
| --- | ||
|
|
||
| <code src="../../examples/popup-render.tsx"></code> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,6 +33,7 @@ | |
| "build": "dumi build", | ||
| "compile": "father build", | ||
| "coverage": "father test --coverage", | ||
| "tsc": "bunx tsc --noEmit", | ||
| "deploy": "UMI_ENV=gh npm run build && gh-pages -d dist", | ||
| "lint": "eslint src/ examples/ --ext .tsx,.ts,.jsx,.jsx", | ||
| "now-build": "npm run build", | ||
|
|
@@ -43,9 +44,9 @@ | |
| }, | ||
| "dependencies": { | ||
| "@rc-component/select": "~1.0.0", | ||
| "@rc-component/tree": "~1.0.0", | ||
| "@rc-component/util": "^1.2.1", | ||
| "classnames": "^2.3.1", | ||
| "rc-tree": "~5.13.1" | ||
| "classnames": "^2.3.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@rc-component/father-plugin": "^2.0.2", | ||
|
|
@@ -55,8 +56,8 @@ | |
| "@types/classnames": "^2.2.6", | ||
| "@types/enzyme": "^3.1.15", | ||
| "@types/jest": "^29.4.0", | ||
| "@types/react": "^17.0.38", | ||
| "@types/react-dom": "^18.0.11", | ||
| "@types/react": "^19.0.0", | ||
| "@types/react-dom": "^19.0.0", | ||
|
Comment on lines
+59
to
+60
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. React 类型定义版本升级与 React 版本不匹配 |
||
| "@types/warning": "^3.0.0", | ||
| "@umijs/fabric": "^4.0.0", | ||
| "array-tree-filter": "^3.0.2", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
事件处理器更新不完整
根据 PR 的目标是废弃旧 API,
onPopupVisibleChange也应该更新为新的 API 名称。🏁 Script executed:
Length of output: 267
请更新所有事件处理器引用
根据最新的检查,在
examples/visible.tsx(第 75 行)以及src/Cascader.tsx中(例如第 109、212、363 和 455 行)的代码依然使用了旧 APIonPopupVisibleChange。而本次 PR 的目标是废弃旧 API,因此需要将所有相关引用统一更新为新版 APIonDropdownVisibleChange。示例修改差异:
请同步检查并更新
src/Cascader.tsx中所有涉及该事件处理器的位置,以确保整个代码库的一致性。📝 Committable suggestion