-
-
Notifications
You must be signed in to change notification settings - Fork 106
refactor: migrate to @rc-component namespace and update dependencies #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
""" Walkthrough本次变更主要涉及更新多个文件中模块的导入路径,将之前指向 Changes
Possibly related PRs
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
tests/ssr.spec.tsxOops! Something went wrong! :( ESLint: 8.57.1 Error: Cannot read config file: /.eslintrc.js
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (6)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #480 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 146 146
Branches 54 54
=========================================
Hits 146 146 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
39-39: 更新 prepublishOnly 脚本
脚本修改为"npm run compile && rc-np",请验证rc-np工具在发布流程中的行为与之前的np工具保持一致,确保发布流程不受影响。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
package.json(3 hunks)src/Drawer.tsx(2 hunks)src/DrawerPopup.tsx(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- src/Drawer.tsx
- src/DrawerPopup.tsx
🔇 Additional comments (5)
package.json (5)
2-3: 更新包名称与版本信息
包名称已正确更新为@rc-component/drawer,版本号也重置为1.0.0。请确保所有引用此包的文档和依赖项也做相应更新。
46-49: 更新依赖项到新命名空间
将依赖项迁移到新的命名空间,包括@rc-component/motion、@rc-component/portal和@rc-component/util,同时新增了classnames。需要确认这些依赖版本满足项目需求并与其他模块兼容。
53-61: 更新开发依赖与类型定义
在 devDependencies 中已将np替换为@rc-component/np并更新了@types/react及@types/react-dom至^19.0.0。这有助于保持与 React 19 相关的类型和工具链一致,请确认后续开发和 CI 流程正常运行。
75-76: 更新 React 与 React-Dom 开发版本
开发依赖中的react与react-dom已更新为^19.0.0。虽然 peerDependencies 中要求版本为>=18.0.0,但此处建议检查项目的兼容性和用户的使用情况,确保不会因版本差异产生潜在问题。
82-83: 审核 peerDependencies 设置
peerDependencies 中的react和react-dom已更新为>=18.0.0,与开发依赖的更新版本基本匹配。请确认用户在安装时能正确获取所需版本,防止版本冲突问题。
|
@zombieJ is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
Summary by CodeRabbit
Chores
Refactor
Tests