Skip to content

fix: setFieldValue should reset validation #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zombieJ merged 1 commit into from
Dec 12, 2024
Merged

fix: setFieldValue should reset validation #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/useForm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,6 +787,8 @@ export class FormStore {
{
name,
value,
errors: [],
warnings: [],
},
]);
};
Expand Down
27 changes: 27 additions & 0 deletions tests/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,4 +996,31 @@ describe('Form.Basic', () => {
expect(formRef.current?.getFieldError('light')).toHaveLength(0);
expect(formRef.current?.getFieldError('bamboo')).toHaveLength(0);
});

it('setFieldValue should reset errors', async () => {
const formRef = React.createRef<FormRef>();

const Demo: React.FC = () => (
<Form ref={formRef}>
<Field name="light" rules={[{ validator: () => Promise.reject('No!') }]}>
<Input />
</Field>
</Form>
);

render(<Demo />);

// Mock error first
await act(async () => {
await formRef.current?.validateFields().catch(() => {});
Copy link
Contributor

@crazyair crazyair Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.catch(() => {}) 这点不写也可以吧

Copy link

@nqhd3v nqhd3v Mar 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think he wrote this to prevent it console.error when run test

});
expect(formRef.current?.getFieldError('light')).toHaveLength(1);

// setFieldValue
await act(async () => {
formRef.current?.setFieldValue('light', 'Bamboo');
await Promise.resolve();
});
expect(formRef.current?.getFieldError('light')).toHaveLength(0);
});
});
Loading