Skip to content

fix: setFieldValue should be touched #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

fix: setFieldValue should be touched #759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/useForm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,6 +812,7 @@ export class FormStore {
value,
errors: [],
warnings: [],
touched: true,
},
]);
};
Expand Down
13 changes: 13 additions & 0 deletions tests/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,6 +885,10 @@ describe('Form.Basic', () => {
Array.from(container.querySelectorAll<HTMLInputElement>('input')).map(input => input?.value),
).toEqual(['bamboo', 'little', 'light', 'nested']);

// Check initial touched state
expect(formRef.current.isFieldTouched(['list', 1])).toBeFalsy();
expect(formRef.current.isFieldTouched(['nest', 'target'])).toBeFalsy();

// Set
act(() => {
formRef.current.setFieldValue(['list', 1], 'tiny');
Expand All @@ -894,6 +898,15 @@ describe('Form.Basic', () => {
expect(
Array.from(container.querySelectorAll<HTMLInputElement>('input')).map(input => input?.value),
).toEqual(['bamboo', 'tiny', 'light', 'match']);

// Check that setFieldValue DOES set touched to true
// (setFieldValue internally calls setFields with touched: true)
expect(formRef.current.isFieldTouched(['list', 1])).toBeTruthy();
expect(formRef.current.isFieldTouched(['nest', 'target'])).toBeTruthy();

// Verify other fields remain untouched
expect(formRef.current.isFieldTouched(['list', 0])).toBeFalsy();
expect(formRef.current.isFieldTouched(['list', 2])).toBeFalsy();
});

it('onMetaChange should only trigger when meta changed', () => {
Expand Down