fix:submenu overflow popupoffset #690
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoyo837
reviewed
Mar 17, 2024
| internalPopupClose={len === 0} | ||
| popupClassName={overflowedIndicatorPopupClassName} | ||
| popupOffset={overflowPopupOffset || [10, 15]} | ||
| > |
There was a problem hiding this comment.
i refer rc-menu docs's demo
if not, what value is appropriate
|
And, some new test case is needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #690 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 27 27
Lines 721 722 +1
Branches 196 199 +3
=======================================
+ Hits 718 719 +1
Misses 3 3 ☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Mar 18, 2024
| forceSubMenuRender?: boolean; | ||
| triggerSubMenuAction?: TriggerSubMenuAction; | ||
| builtinPlacements?: BuiltinPlacements; | ||
| overflowPopupOffset?: number[] |
i have no idea how to mock overflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #668
background
When we set the popupOffset, we expect all submenus to have an offset from the menu item. However, when the window width is small, the menu overflows. The overflow, represented by ... as an overflow placeholder, does not have a submenu offset.
It is necessary to fix it
before fix:
menu.mov
after fix:
menu.mov