Skip to content

chore: rm useless code #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2024
Merged

chore: rm useless code #900

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00e1871
chore: rm useless code
zombieJ Dec 5, 2024
6912515
fix: lint
zombieJ Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/generate/dayjs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,13 @@ const parseLocale = (locale: string) => {
return mapLocale || locale.split('_')[0];
};

/* istanbul ignore next */
const parseNoMatchNotice = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是个空方法，删掉？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里没删是留着写原因的，否则万一以后遇到格式不匹配又会再写一遍。大家来回捯饬。

/* istanbul ignore next */
noteOnce(false, 'Not match any format. Please help to fire a issue about this.');
// zombieJ:
// When user typing, its always miss match format.
// This check is meaningless.
// https://github.com/ant-design/ant-design/issues/51839
// noteOnce(false, 'Not match any format. Please help to fire a issue about this.');
};

const generateConfig: GenerateConfig<Dayjs> = {
Expand Down
Loading