feat: Add Marathi Language Support #943
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Walkthrough新增 Marathi（mr_IN）本地化模块：在 Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @divyeshagrawal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the application's internationalization capabilities by integrating Marathi language support. It provides a complete set of localized strings for date and time selection components, ensuring a more inclusive and user-friendly experience for Marathi-speaking users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces Marathi language support by adding a new locale file mr_IN.ts. The provided translations are a great start. My review includes suggestions to make the localization more complete by adding properties for short day/month names and region-specific date formats. These changes will improve the user experience and ensure consistency across the component.
| const locale: Locale = { | ||
| ...commonLocale, | ||
| locale: 'mr_IN', | ||
| today: 'आज', | ||
| now: 'आता', | ||
| backToToday: 'आजवर परत जा', | ||
| ok: 'ठीक आहे', | ||
| clear: 'साफ करा', | ||
| week: 'आठवडा', | ||
| month: 'महिना', | ||
| year: 'वर्ष', | ||
| timeSelect: 'वेळ निवडा', | ||
| dateSelect: 'दिनांक निवडा', | ||
| weekSelect: 'आठवडा निवडा', | ||
| monthSelect: 'महिना निवडा', | ||
| yearSelect: 'वर्ष निवडा', | ||
| decadeSelect: 'दशक निवडा', | ||
|
|
||
| previousMonth: 'मागील महिना (पेजअप)', | ||
| nextMonth: 'पुढचा महिना (पेजडाउन)', | ||
| previousYear: 'गेल्या वर्षी (Ctrl + left)', | ||
| nextYear: 'पुढचे वर्ष (Ctrl + right)', | ||
| previousDecade: 'मागील दशक', | ||
| nextDecade: 'पुढचे दशक', | ||
| previousCentury: 'मागील शतक', | ||
| nextCentury: 'पुढचे शतक', | ||
| }; |
There was a problem hiding this comment.
The locale object is missing shortWeekDays and shortMonths properties. While these are optional in the Locale type, their absence can lead to an incomplete translation. For instance, the calendar header for days of the week and the month selection dropdown might not be translated. To ensure a complete localization for Marathi, please add these properties.
Example:
shortWeekDays: ['रवि', 'सोम', 'मंगळ', 'बुध', 'गुरु', 'शुक्र', 'शनि'],
shortMonths: ['जाने', 'फेब्रु', 'मार्च', 'एप्रि', 'मे', 'जून', 'जुलै', 'ऑग', 'सप्टें', 'ऑक्टो', 'नोव्हें', 'डिसें'],Please verify and use the appropriate short forms for Marathi.
| const locale: Locale = { | ||
| ...commonLocale, | ||
| locale: 'mr_IN', | ||
| today: 'आज', | ||
| now: 'आता', | ||
| backToToday: 'आजवर परत जा', | ||
| ok: 'ठीक आहे', | ||
| clear: 'साफ करा', | ||
| week: 'आठवडा', | ||
| month: 'महिना', | ||
| year: 'वर्ष', | ||
| timeSelect: 'वेळ निवडा', | ||
| dateSelect: 'दिनांक निवडा', | ||
| weekSelect: 'आठवडा निवडा', | ||
| monthSelect: 'महिना निवडा', | ||
| yearSelect: 'वर्ष निवडा', | ||
| decadeSelect: 'दशक निवडा', | ||
|
|
||
| previousMonth: 'मागील महिना (पेजअप)', | ||
| nextMonth: 'पुढचा महिना (पेजडाउन)', | ||
| previousYear: 'गेल्या वर्षी (Ctrl + left)', | ||
| nextYear: 'पुढचे वर्ष (Ctrl + right)', | ||
| previousDecade: 'मागील दशक', | ||
| nextDecade: 'पुढचे दशक', | ||
| previousCentury: 'मागील शतक', | ||
| nextCentury: 'पुढचे शतक', | ||
| }; |
There was a problem hiding this comment.
The locale object does not specify any field...Format properties, such as fieldDateFormat. The component will fall back to default formats like YYYY-MM-DD. In India, the DD-MM-YYYY format is more common. To align with local conventions and improve user experience, I recommend adding format specifiers.
Example:
fieldDateFormat: 'DD-MM-YYYY',
fieldDateTimeFormat: 'DD-MM-YYYY HH:mm:ss',
fieldMonthFormat: 'MM-YYYY',You can add other format fields as needed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #943 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 65 65
Lines 2682 2682
Branches 721 741 +20
=======================================
Hits 2650 2650
Misses 29 29
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Summary by CodeRabbit