Skip to content

fix: tagRender should not be called when value is empty #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2025
Merged

fix: tagRender should not be called when value is empty #1109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Selector/MultipleSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@ const SelectSelector: React.FC<SelectorProps> = (props) => {
};

const renderRest = (omittedValues: DisplayValueType[]) => {
// https://github.com/ant-design/ant-design/issues/48930
if (!values.length) {
return null;
}
const content =
typeof maxTagPlaceholder === 'function'
? maxTagPlaceholder(omittedValues)
Expand Down
14 changes: 14 additions & 0 deletions tests/Tags.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,20 @@ describe('Select.Tags', () => {
});
});

// https://github.com/ant-design/ant-design/issues/48930
it('should not call tagRender when value is empty', () => {
const tagRender = jest.fn();
render(
<Select
mode="tags"
value={[]}
tagRender={tagRender}
options={[{ value: 'light' }, { value: 'dark' }]}
/>,
);
expect(tagRender).not.toHaveBeenCalled();
});

it('disabled', () => {
const tagRender = jest.fn();
render(
Expand Down
Loading