-
-
Notifications
You must be signed in to change notification settings - Fork 478
feat: support classnames and styles #1128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1ded65d
feat: support classnames and styles
thinkasany 986a688
save
thinkasany 45599f6
rm
thinkasany e609a33
rm
thinkasany 6c7ff1a
item to listItem
thinkasany 6b4dce6
fix
thinkasany 53322ad
fix type
thinkasany File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -107,6 +107,7 @@ export type SelectHandler<ValueType, OptionType extends BaseOptionType = Default | |
|
||
type ArrayElementType<T> = T extends (infer E)[] ? E : T; | ||
|
||
export type SemanticName = 'prefix' | 'suffix' | 'item' | 'list' | 'input'; | ||
|
||
export interface SelectProps<ValueType = any, OptionType extends BaseOptionType = DefaultOptionType> | ||
extends BaseSelectPropsWithoutPrivate { | ||
prefixCls?: string; | ||
|
@@ -157,6 +158,8 @@ export interface SelectProps<ValueType = any, OptionType extends BaseOptionType | |
defaultValue?: ValueType | null; | ||
maxCount?: number; | ||
onChange?: (value: ValueType, option?: OptionType | OptionType[]) => void; | ||
classNames?: Partial<Record<SemanticName, string>>; | ||
styles?: Partial<Record<SemanticName, React.CSSProperties>>; | ||
} | ||
|
||
function isRawValue(value: DraftValueType): value is RawValueType { | ||
|
@@ -204,7 +207,8 @@ const Select = React.forwardRef<BaseSelectRef, SelectProps<any, DefaultOptionTyp | |
labelInValue, | ||
onChange, | ||
maxCount, | ||
|
||
classNames: selectClassNames, | ||
styles, | ||
...restProps | ||
} = props; | ||
|
||
|
@@ -626,8 +630,12 @@ const Select = React.forwardRef<BaseSelectRef, SelectProps<any, DefaultOptionTyp | |
childrenAsData, | ||
maxCount, | ||
optionRender, | ||
classNames: selectClassNames, | ||
styles, | ||
}; | ||
}, [ | ||
selectClassNames, | ||
styles, | ||
maxCount, | ||
parsedOptions, | ||
displayOptions, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BaseSelect 里不应该反向引用 Select 的定义,因为 TreeSelect 和 Cascader 里是没有这个的。BaseSelect 应该只有
'prefix' | 'suffix' | 'input'
,然后 Select 里拓展出来