fix: Fix search props leaked to DOM #1157

EmilyyyLiu · 2025-06-25T05:53:22Z

修复部分search配置透出到dom上的报错

Summary by CodeRabbit

修复问题
- 优化了过滤相关属性的处理，防止无关属性被传递到 DOM 元素，提升组件兼容性和稳定性。

vercel · 2025-06-25T05:53:26Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
select	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 25, 2025 7:01am

coderabbitai · 2025-06-25T05:53:47Z

Caution

Review failed

The head commit changed during the review from 403f7a2 to a51028c.

"""

Walkthrough

本次变更扩展了 OMIT_DOM_PROPS 常量，将 filterOption、optionFilterProp 和 filterSort 三个过滤相关属性加入忽略列表，防止这些属性被传递到 DOM 元素上。未对导出或公共实体的声明进行任何修改。

Changes

文件	变更摘要
src/Select.tsx	扩展 `OMIT_DOM_PROPS`，新增 `filterOption`、`optionFilterProp`、`filterSort` 三项过滤相关属性。

Suggested reviewers

zombieJ

Possibly related PRs

feat: combine search props #1152：重构了搜索相关属性的处理，将 filterOption、optionFilterProp 和 filterSort 整合到 showSearch 配置对象中，并更新了组件逻辑，与本次对这些属性的忽略处理直接相关。

Poem

小兔挥笔写新篇，
过滤属性添几员。
DOM 轻装不带累，
选择组件更安全。
代码如林风吹过，
清新整洁又一天！ 🐇✨
"""

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/Select.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: Cannot read config file: /.eslintrc.js
Error: Cannot find module '@umijs/fabric/dist/eslint'
Require stack:

/.eslintrc.js
/node_modules/.pnpm/@eslint [email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs
/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/cli-engine/cli-engine.js
/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/eslint/eslint.js
/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/eslint/index.js
/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/cli.js
/node_modules/.pnpm/[email protected]/node_modules/eslint/bin/eslint.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1405:15)
at defaultResolveImpl (node:internal/modules/cjs/loader:1061:19)
at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1066:22)
at Module._load (node:internal/modules/cjs/loader:1215:37)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
at Module.require (node:internal/modules/cjs/loader:1491:12)
at require (node:internal/modules/helpers:135:16)
at Object. (/.eslintrc.js:1:14)
at Module._compile (node:internal/modules/cjs/loader:1734:14)

src/hooks/useSearchConfig.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: Cannot read config file: /.eslintrc.js
Error: Cannot find module '@umijs/fabric/dist/eslint'
Require stack:

/.eslintrc.js
/node_modules/.pnpm/@eslint [email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs
/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/cli-engine/cli-engine.js
/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/eslint/eslint.js
/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/eslint/index.js
/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/cli.js
/node_modules/.pnpm/[email protected]/node_modules/eslint/bin/eslint.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1405:15)
at defaultResolveImpl (node:internal/modules/cjs/loader:1061:19)
at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1066:22)
at Module._load (node:internal/modules/cjs/loader:1215:37)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
at Module.require (node:internal/modules/cjs/loader:1491:12)
at require (node:internal/modules/helpers:135:16)
at Object. (/.eslintrc.js:1:14)
at Module._compile (node:internal/modules/cjs/loader:1734:14)

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate Unit Tests

Create PR with Unit Tests
Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-06-25T05:54:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (9b60445) to head (a51028c).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1157   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files          39       39           
  Lines        1482     1483    +1     
  Branches      421      449   +28     
=======================================
+ Hits         1454     1455    +1     
  Misses         28       28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/Select.tsx (1)
61-68: 考虑同步遗漏的搜索相关属性，避免后续再出现 DOM 警告

此次补充的属性可以有效阻断过滤相关配置泄漏到原生元素，但目前 SearchConfig 中仍有 searchValue、autoClearSearchValue、onSearch 等字段同样会通过 restProps 透传，理论上也可能成为未知 DOM 属性并触发 React 警告。建议一并加入到 OMIT_DOM_PROPS，或在 BaseSelect 内部集中维护完整白名单，减少未来遗漏的概率。

可选修改示例：
 const OMIT_DOM_PROPS = [
   'inputValue',
+  'onSearch',
+  'searchValue',
+  'autoClearSearchValue',
   'filterOption',
   'optionFilterProp',
   'filterSort',
   'filterTreeNode',
   'treeNodeFilterProp',
 ];
如无特殊理由排除上述字段，请补充后再运行一轮 CI，确保没有新的 “unknown prop” 报错。

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b60445 and e3af7a4.

📒 Files selected for processing (1)

src/Select.tsx (1 hunks)

src/Select.tsx

fix: Fix search props leaked to DOM

e3af7a4

vercel bot deployed to Preview June 25, 2025 05:54 View deployment

coderabbitai bot reviewed Jun 25, 2025

View reviewed changes

zombieJ reviewed Jun 25, 2025

View reviewed changes

src/Select.tsx Outdated Show resolved Hide resolved

fix: Remove filterTreeNode and treeNodeFilterProp from OMIT_DOM_PROPS

17dca56

vercel bot deployed to Preview June 25, 2025 06:15 View deployment

fix: Transfer search props to useSearchConfig

403f7a2

vercel bot deployed to Preview June 25, 2025 06:59 View deployment

fix: fix lint error

a51028c

vercel bot deployed to Preview June 25, 2025 07:01 View deployment

zombieJ approved these changes Jun 25, 2025

View reviewed changes

zombieJ merged commit b7c92b3 into react-component:master Jun 25, 2025
10 checks passed

coderabbitai bot mentioned this pull request Sep 7, 2025

fix: Select dropdown on search not scroll to the correct options #1161

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: Fix search props leaked to DOM #1157

fix: Fix search props leaked to DOM #1157

Uh oh!

EmilyyyLiu commented Jun 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Jun 25, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 25, 2025 •

edited

Loading

Review failed

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Jun 25, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix: Fix search props leaked to DOM #1157

fix: Fix search props leaked to DOM #1157

Uh oh!

Conversation

EmilyyyLiu commented Jun 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Suggested reviewers

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

EmilyyyLiu commented Jun 25, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Jun 25, 2025 •

edited

Loading

coderabbitai bot commented Jun 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jun 25, 2025 •

edited

Loading