Skip to content

fix: not prevent when child #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2025
+26 −2
Merged

fix: not prevent when child #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/SelectInput/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,8 @@ export default React.forwardRef<SelectInputRef, SelectInputProps>(function Selec
// ====================== Open ======================
const onInternalMouseDown: SelectInputProps['onMouseDown'] = useEvent((event) => {
if (!disabled) {
if (event.target !== getDOM(inputRef.current)) {
const inputDOM = getDOM(inputRef.current);
if (inputDOM && event.target !== inputDOM && !inputDOM.contains(event.target as Node)) {
Copy link

@gemini-code-assist gemini-code-assist bot Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better type safety and to avoid an explicit type cast, it's preferable to use a type guard like instanceof Node to verify that event.target is a DOM node before using DOM-specific methods such as contains.

Suggested change
if (inputDOM && event.target !== inputDOM && !inputDOM.contains(event.target as Node)) {
if (inputDOM && event.target instanceof Node && event.target !== inputDOM && !inputDOM.contains(event.target)) {

event.preventDefault();
}

Expand Down
25 changes: 24 additions & 1 deletion tests/components.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { render } from '@testing-library/react';
import { createEvent, fireEvent, render } from '@testing-library/react';
import React from 'react';
import Select from '../src';
import { injectRunAllTimers } from './utils/common';
Expand All @@ -22,4 +22,27 @@ describe('Select.Components', () => {

expect(container.querySelector('textarea')?.getAttribute('placeholder')).toBe('test');
});

it('should not preventDefault when customize input contains input', () => {
const preventDefault = jest.fn();
const { container } = render(
<Select
mode="combobox"
getInputElement={() => (
<div>
<textarea />
</div>
)}
/>,
);

const textareaEle = container.querySelector('textarea');

// Create mouseDown event on the selector element
const mouseDownEvent = createEvent.mouseDown(textareaEle);
mouseDownEvent.preventDefault = preventDefault;
fireEvent(textareaEle, mouseDownEvent);

expect(preventDefault).not.toHaveBeenCalled();
});
});
Loading