chore: migrate to @rc-component namespace #779
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
""" Walkthrough此次更新主要涉及项目的元数据和依赖管理调整。在 package.json 中，包名更新为 Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #779 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 18 18
Lines 771 771
Branches 227 227
=======================================
Hits 763 763
Misses 8 8 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
package.json (1)
10-17: 🛠️ Refactor suggestion需要更新仓库相关 URL
仓库相关的 URL 仍然使用旧的命名空间路径。建议更新以下字段以保持一致性：
- homepage
- bugs.url
- repository.url
建议应用以下修改：
- "homepage": "http://github.com/react-component/tabs", + "homepage": "http://github.com/react-component/tabs-next", "bugs": { - "url": "http://github.com/react-component/tabs/issues" + "url": "http://github.com/react-component/tabs-next/issues" }, "repository": { "type": "git", - "url": "[email protected]:react-component/tabs.git" + "url": "[email protected]:react-component/tabs-next.git" },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
package.json(2 hunks)tsconfig.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: test / react component workflow
🔇 Additional comments (3)
package.json (3)
2-3: 版本号变更需要说明包名从
rc-tabs更改为@rc-component/tabs的同时，版本号从15.5.1重置为1.0.0。这是一个重大变更，建议：
- 在 CHANGELOG 中详细说明此次变更的原因和影响
- 在发布说明中标注此版本与旧版本的对应关系
43-45: 建议评估其他 rc- 依赖的迁移*注意到部分依赖仍在使用
rc-前缀：
- rc-dropdown
- rc-menu
- rc-motion
建议评估这些依赖是否也需要迁移到
@rc-component命名空间。
39-46: 依赖更新看起来不错！成功完成了以下迁移：
- 添加
@rc-component/resize-observer替换rc-resize-observer- 添加
@rc-component/util作为新依赖- 移除了不再需要的
@babel/runtime
| "rc-tabs": [ | ||
| "src/" | ||
| ], | ||
| "@rc-component/tabs": [ | ||
| "src/" | ||
| ] |
There was a problem hiding this comment.
🛠️ Refactor suggestion
建议移除旧的路径映射
当前配置同时保留了 rc-tabs 和 @rc-component/tabs 的路径映射，这可能会导致混淆。建议在迁移到新的命名空间时移除旧的映射。
建议应用以下修改：
- "rc-tabs": [
- "src/"
- ],
"@rc-component/tabs": [
"src/"
]📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "rc-tabs": [ | |
| "src/" | |
| ], | |
| "@rc-component/tabs": [ | |
| "src/" | |
| ] | |
| "@rc-component/tabs": [ | |
| "src/" | |
| ] |
package.json
Outdated
| "lint": "eslint src/ docs/examples/ --ext .tsx,.ts,.jsx,.js", | ||
| "now-build": "npm run build", | ||
| "prepublishOnly": "npm run lint && npm run test && npm run compile && np --yolo --no-publish", | ||
| "prepublishOnly": "npm run lint && npm run test && npm run compile && rc-np --yolo --no-publish", |
2 participants
Summary by CodeRabbit