Skip to content

fix: Tabs press Enter/Space on active tab should not trigger onChange #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

fix: Tabs press Enter/Space on active tab should not trigger onChange #794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/TabNavList/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ const TabNavList = React.forwardRef<HTMLDivElement, TabNavListProps>((props, ref
case 'Enter':
case 'Space': {
e.preventDefault();
onTabClick(focusKey, e);
onTabClick(activeKey, e);
break;
}
// Backspace
Expand Down
5 changes: 4 additions & 1 deletion tests/accessibility.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,23 +91,26 @@ describe('Tabs.Accessibility', () => {

it('should activate tab on Enter/Space', async () => {
const onTabClick = jest.fn();
const onChange = jest.fn();
const user = userEvent.setup();

render(createTabs({ onTabClick }));
render(createTabs({ onTabClick, onChange }));

// jump to first tab
await user.tab();

// activate tab
await user.keyboard(' ');
expect(onTabClick).toHaveBeenCalledTimes(1);
expect(onChange).not.toHaveBeenCalled();

// move focus to second tab
await user.keyboard('{ArrowRight}');

// activate tab
await user.keyboard('{Enter}');
expect(onTabClick).toHaveBeenCalledTimes(2);
expect(onChange).not.toHaveBeenCalled();
});

it('should not navigate to disabled tabs', async () => {
Expand Down