Skip to content

fix: force update to keep disable state work #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 25, 2024
Merged

fix: force update to keep disable state work #612

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c098a17
fix: force update to keep disable state work
aojunhao123 Dec 24, 2024
a5b1e9b
refactor: replace disabled ref cache with state
aojunhao123 Dec 25, 2024
4f4b124
perf: remove unnecessary setState and init map
aojunhao123 Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/OptionList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,18 @@ const OptionList: React.ForwardRefRenderFunction<ReviseRefOptionListProps> = (_,
// ========================= Disabled =========================
const disabledCacheRef = React.useRef<Map<string, boolean>>(new Map());

// Clear cache if `leftMaxCount` changed
// Force update is needed since clearing cache alone doesn't trigger
// a recalculation of node disabled states
const [, setForceUpdate] = React.useState({});

// When leftMaxCount changes, we need to:
// 1. Clear the disabled state cache
// 2. Trigger a re-render to recalculate all node disabled states
// This ensures parent nodes are properly disabled when max count is reached
React.useEffect(() => {
if (leftMaxCount) {
disabledCacheRef.current.clear();
setForceUpdate({});
}
}, [leftMaxCount]);

Expand Down
Loading