chore!: drop support for legacy Node.js versions #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11526169352Details
💛 - Coveralls |
BREAKING CHANGE: drops support for all legacy Node.js versions (below version 18) Signed-off-by: Jon Koops <[email protected]>
jonkoops
force-pushed
the
drop-old-node
branch
from
a83eec5 to
b5aeed8
Compare
Collaborator
Author
|
Marking this one as ready to review. I've rebased the PR and fixed the conflicts. This one is now targeting the |
rolandjitsu
approved these changes
Oct 26, 2024
|
🎉 This PR is included in version 2.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
Author
|
Nice, looks like we successfully published that beta version! |
Collaborator
Indeed it has. Maintenance branches should also work if/when we decide to patch the last version with commonjs support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: drops support for all legacy Node.js versions (below version 18)
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Drops support for versions of Node.js that no longer receive active support. This simplifies the CI and makes it easier to do future maintenance.
Does this PR introduce a breaking change?
Yes, this drops support for any version of Node.js older than 18. Realistically though this library is likely not often used in a Node.js environment, so this should not affect many users.
Other information
None.