Skip to content

Conversation

@rolandjitsu
Copy link
Collaborator

@rolandjitsu rolandjitsu commented Oct 27, 2024

What kind of change does this PR introduce?

  • Bug Fix
  • Feature
  • Refactoring
  • Style
  • Build
  • Chore
  • Documentation
  • CI

Did you add tests for your changes?

  • Yes, my code is well tested
  • Not relevant

If relevant, did you update the documentation?

  • Yes, I've updated the documentation
  • Not relevant

Summary
Explain the motivation for making this change. What existing problem does the pull request solve?
Try to link to an open issue for more information.

Address #69.

Does this PR introduce a breaking change?
If this PR introduces a breaking change, please describe the impact and a migration path for existing applications.

Yes. The path will be relative when falling back to the file name:

// before
console.log(file.path)
// test.json

// after
console.log(file.path)
// ./test.json

Other information

Original PR at #70.

@coveralls
Copy link

coveralls commented Oct 27, 2024

Pull Request Test Coverage Report for Build 11612627437

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11523128423: 0.0%
Covered Lines: 92
Relevant Lines: 92

💛 - Coveralls

BREAKING CHANGE: `{path}` is now relative when falling back to the file name
@rolandjitsu rolandjitsu marked this pull request as ready for review October 31, 2024 13:16
@rolandjitsu rolandjitsu changed the title feat: always populate {relativePath} for access across browser and el… feat!: always set a {relativePath} Oct 31, 2024
@rolandjitsu rolandjitsu mentioned this pull request Nov 1, 2024
12 tasks
@rolandjitsu rolandjitsu merged commit 0dff2f9 into master Nov 2, 2024
8 checks passed
@github-actions
Copy link

github-actions bot commented Nov 2, 2024

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rolandjitsu rolandjitsu deleted the feat/rel-path branch November 2, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants