Skip to content

chore: apply prettier formatting #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2024
Merged

chore: apply prettier formatting #1101

merged 2 commits into from
Dec 14, 2024

Conversation

@marcalexiei
Copy link
Contributor

@marcalexiei marcalexiei commented Dec 13, 2024 •
edited
Loading

Part of #1098.

Note

Based upon #1100 (I marked this PR as draft, will rebase and make it ready for review after #1100 is merged).

  • Fix format script to include .
  • Added format:fix to automatically apply format fixes
  • Apply prettier styles to all relevant files (.gitgnore files and pnpm-lock.yaml has been excluded)
  • Added new ci.yml workflows to run format script on pull_request and push events targeting master branch
    • This workflow will include lint and typecheck scripts execution in the near future
    • I added .nvmrc file and packageManager property in package.json to simplify Node and pnpm setup in the ci.yml workflow

@vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-hook-form-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2024 7:02am

@marcalexiei marcalexiei mentioned this pull request Dec 13, 2024
Closed
8 tasks
@marcalexiei marcalexiei marked this pull request as draft December 13, 2024 18:32
@marcalexiei marcalexiei marked this pull request as ready for review December 14, 2024 07:02
@marcalexiei marcalexiei mentioned this pull request Dec 14, 2024
Merged
bluebill1049
bluebill1049 approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bluebill1049 bluebill1049 merged commit 7e5d219 into react-hook-form:master Dec 14, 2024
3 checks passed
@marcalexiei marcalexiei deleted the format-fix branch December 14, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluebill1049 bluebill1049 bluebill1049 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcalexiei @bluebill1049