Skip to content

Conversation

@marcalexiei
Copy link
Contributor

Part of #1098.

Enabled following ts compilerOptions:

  • strict
  • noImplicitAny
  • noImplicitThis
  • noUnusedLocals
  • noUnusedParameters
  • noImplicitReturns
  • noFallthroughCasesInSwitch

Most of the changes involves only type related expect for few exceptions:

  1. src/components/FormFields.tsx I added a getNumericValidationFor to help creating register#RegisterOptions
  2. Removed few spreads when rendering JSX components. Plain property should be enough

@vercel
Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-hook-form-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 8:21am

Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@bluebill1049 bluebill1049 merged commit cc6ed5a into react-hook-form:master Dec 17, 2024
5 checks passed
@marcalexiei marcalexiei deleted the strict-mode branch December 20, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants