workspace: add monorepo level lint, setup JSON and MD lint, fix warnings #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Spotted that we only lint
websitedirectory content, not the whole monorepo.How
Add workspace level ESLint setup, add JSON and MD files linting. Reuse global configuration within
websiteproject, fix all new warnings.In the process I have also flipped value of
singleQuotePrettier config to match what was there prior previous change from today to have one convention across the whole codebase, since most of the scripts outsidewebsitedirectory were using single quotes. This flip is the source of most of the changes inwebsitedirectory.Additionally, the workspace lint step has been added to
test-js.ymlworkflow to ensure correctness via CI for PR.