Just a minor reference correction #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
reviewed
Jul 29, 2025
template/ios/Podfile
Outdated
| @@ -24,7 +24,7 @@ target 'HelloWorld' do | |||
| ) | |||
|
|
|||
| post_install do |installer| | |||
| # https://github.com/facebook/react-native/blob/main/packages/react-native/scripts/react_native_pods.rb#L197-L202 | |||
| # https://github.com/facebook/react-native/blob/main/packages/react-native/scripts/react_native_pods.rb#L452-L464 | |||
There was a problem hiding this comment.
cc @cipolleschi either we use a permalink or the lines will keep on changing here.
There was a problem hiding this comment.
I think we can just remove them... I don't see the point in having them pointing to the function in react_native_pods... people can just search the react native code for that function to find it.
There was a problem hiding this comment.
Ok let's remove it then @riteshshukla04
cortinico
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Just a minor reference correction. The previous URL doesn't take to right function
Changelog:
[IOS][CHANGED] Minor Reference correction
Test Plan:
N/A