Skip to content

Just a minor reference correction #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2025
Merged

Just a minor reference correction #162

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27d616e
Update Podfile
riteshshukla04 Jul 29, 2025
001a31e
Update Podfile
riteshshukla04 Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion template/ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ target 'HelloWorld' do
)

post_install do |installer|
# https://github.com/facebook/react-native/blob/main/packages/react-native/scripts/react_native_pods.rb#L197-L202
# https://github.com/facebook/react-native/blob/main/packages/react-native/scripts/react_native_pods.rb#L452-L464
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @cipolleschi either we use a permalink or the lines will keep on changing here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just remove them... I don't see the point in having them pointing to the function in react_native_pods... people can just search the react native code for that function to find it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok let's remove it then @riteshshukla04

react_native_post_install(
installer,
config[:reactNativePath],
Expand Down