[0.78-stable] Android targetSdk 35 update - remove SafeAreaView and use padding #99
Merged
cortinico merged 1 commit intoreact-native-community:0.78-stablefrom Jan 14, 2025
Conversation
cortinico
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick commit from PR #95
below is copied from the PR
Summary:
This is an alternative implementation for PR #94 which removes SafeAreaView entirely and uses magic padding for both iOS and Android.
Updating to targetSdk 35 on Android enforces edge-to-edge on Android 15+.
We decided not to use react-native-safe-area-context in the template (PR #84 ) to reduce external dependency although it is the recommendation.
To account for UI overlap, we are using a magic padding value for both iOS and Android in the template.
Also SafeAreaView (iOS only) was removed so same code is used on both platforms.
Changelog:
[ANDROID][CHANGED] - update targetSdk to 35 which will enforce edge-to-edge on Android 15+
[GENERAL][REMOVED] - Removed use of SafeAreaView
Test Plan:
ios_hacky_padding_only.mp4
ios_hacky_padding_only_land.mp4
android_hacky_padding.mp4
android_hacky_padding_land.mp4