Skip to content

fix: correctly replace app name in file path #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025
Merged

fix: correctly replace app name in file path #396

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93daabe
fix: correctly replace app name in file path
vinzscam Feb 20, 2025
17989b3
Update src/components/pages/Home.tsx
vinzscam Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/common/VersionSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ const VersionSelector = ({
showDiff: (args: { fromVersion: string; toVersion: string }) => void
showReleaseCandidates: boolean
appPackage: string
appName: string
appName?: string
}) => {
const { isLoading, isDone, releaseVersions } = useFetchReleaseVersions({
packageName,
Expand Down
19 changes: 7 additions & 12 deletions src/components/pages/Home.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,16 +98,13 @@ const SettingsContainer = styled.div`
flex: 1;
`

const getAppInfoInURL = (): {
appPackage: string
appName: string
} => {
const getAppInfoInURL = () => {
// Parses `/?name=RnDiffApp&package=com.rndiffapp` from URL
const { name, package: pkg } = queryString.parse(window.location.search)

return {
appPackage: pkg as string,
appName: name as string,
appName: name as string | null,
}
}

Expand Down Expand Up @@ -143,11 +140,11 @@ const Home = () => {
})

const appInfoInURL = getAppInfoInURL()
const [appName, setAppName] = useState<string>(appInfoInURL.appName)
const [appPackage, setAppPackage] = useState<string>(appInfoInURL.appPackage)
const [appName, setAppName] = useState(appInfoInURL.appName)
const [appPackage, setAppPackage] = useState(appInfoInURL.appPackage)

// Avoid UI lag when typing.
const deferredAppName = useDeferredValue(appName)
const deferredAppName = useDeferredValue(appName || DEFAULT_APP_NAME)
const deferredAppPackage = useDeferredValue(appPackage)

const homepageUrl = process.env.PUBLIC_URL
Expand Down Expand Up @@ -281,7 +278,7 @@ const Home = () => {
<Input
size="large"
placeholder={DEFAULT_APP_NAME}
value={appName}
value={appName || ''}
onChange={({ target }) => setAppName((value) => target.value)}
/>
</AppNameField>
Expand Down Expand Up @@ -322,9 +319,7 @@ const Home = () => {
shouldShowDiff={shouldShowDiff}
fromVersion={fromVersion}
toVersion={toVersion}
appName={
deferredAppName !== DEFAULT_APP_NAME ? deferredAppName : ''
}
appName={deferredAppName}
appPackage={
deferredAppPackage !== DEFAULT_APP_PACKAGE
? deferredAppPackage
Expand Down
2 changes: 1 addition & 1 deletion src/utils/update-url.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function updateURL({
fromVersion: string
toVersion: string
appPackage: string
appName: string
appName?: string
}) {
const url = new URL(window.location.origin)
url.pathname = window.location.pathname
Expand Down