Skip to content

fix(ios): catch exceptions in open url#1481

Merged
vonovak merged 1 commit intomasterfrom
fix/catch-open-url-exceptions
Dec 23, 2025
Merged

fix(ios): catch exceptions in open url#1481
vonovak merged 1 commit intomasterfrom
fix/catch-open-url-exceptions

Conversation

@vonovak
Copy link
Copy Markdown
Collaborator

@vonovak vonovak commented Dec 23, 2025

(Only concerns expo) this adds a do + catch around the GIDSignIn.sharedInstance.handle method which is known to throw errors in v9 of the native google sign in SDK (which is the subject of this issue: google/GoogleSignIn-iOS#547 (comment))

@vonovak vonovak force-pushed the fix/catch-open-url-exceptions branch 2 times, most recently from 2ba7558 to 22457d8 Compare December 23, 2025 21:27
@vonovak vonovak force-pushed the fix/catch-open-url-exceptions branch from 22457d8 to fa18a79 Compare December 23, 2025 22:20
@vonovak vonovak merged commit 877ffe3 into master Dec 23, 2025
2 checks passed
@vonovak vonovak deleted the fix/catch-open-url-exceptions branch December 23, 2025 22:22
github-actions bot pushed a commit that referenced this pull request Dec 23, 2025
## [16.1.1](v16.1.0...v16.1.1) (2025-12-23)

### Bug Fixes

* **ios:** catch exceptions in open url ([#1481](#1481)) ([877ffe3](877ffe3))

⭐ **Tip**: there's a [paid version of the package](https://universal-sign-in.com/#pricing) with a [new implementation](https://react-native-google-signin.github.io/docs/one-tap), advanced [security features](https://react-native-google-signin.github.io/docs/security), support for [web](https://react-native-google-signin.github.io/docs/setting-up/web), and more features.
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 16.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant