fix(android): package was failing to compile on RN 0.77 #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: > Task :react-native-menu_menu:compileDebugKotlin FAILED e: file:///.../@react-native-menu/menu/android/src/main/java/com/reactnativemenu/MenuView.kt:60:3 'onTouchEvent' overrides nothing. e: file:///.../@react-native-menu/menu/android/src/main/java/com/reactnativemenu/MenuView.kt:61:35 Argument type mismatch: actual type is 'android.view.MotionEvent?', but 'android.view.MotionEvent' was expected.
3 tasks
Contributor
|
@Naturalclar Could you publish a new version with this PR? |
Member
|
@fobos531 done! released as 1.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When trying to compile our app with the new RN 0.77 we ran into the following error:
Test Plan
Compiling on RN 0.77 should work