Add Fabric Commands Support for Android MenuView Component #1152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements Fabric commands support for the Android MenuView component, enabling proper command handling in React Native's New Architecture while maintaining full backward compatibility with the legacy Paper architecture.
Changes Made
Android Native Layer (
MenuViewManagerBase.kt)receiveCommand(root: MenuView, commandId: String, args: ReadableArray?)method to handle string-based commands used by FabricCOMMAND_SHOWfromvaltoconst valand addedNEW_ARCH_COMMAND_SHOWconstant for Fabric compatibilityReact Native Layer (
UIMenuView.android.tsx)global.nativeFabricUIManagercodegenNativeCommandsfor type-safe command dispatchUIManager.dispatchViewManagerCommandTechnical Details
Architecture Detection
The component now detects the current React Native architecture at runtime:
Command Handling
"show") with codegen-generated command interfaces1) with traditional UIManager dispatchTesting
Breaking Changes
None. This change is fully backward compatible.
Related Issues
Fixes #1001 - Error: Exception in HostFunction: com.facebook.react.bridge.UnexpectedNativeTypeException when calling
menuRef.current?.show()in React Native 0.76.3