Skip to content

Fix picker label.textColor double conversion with Fabric #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArnaudDerosin wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −1
Open

Fix picker label.textColor double conversion with Fabric #667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ios/RNCPicker.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,15 @@ - (UIView *)pickerView:(UIPickerView *)pickerView
RNCPickerLabel* label = view.subviews[0];
label.font = _font;

label.textColor = [RCTConvert UIColor:_items[row][@"textColor"]] ?: _color;
id colorValue = _items[row][@"textColor"];

// New Architecture: color props is already resolved to UIColor
// Old architecture: JS color value, RCTConvert is required
if ([colorValue isKindOfClass:[UIColor class]]) {
label.textColor = (UIColor *)colorValue;
} else {
label.textColor = [RCTConvert UIColor:colorValue] ?: _color;
}

label.textAlignment = _textAlign;
label.text = [self pickerView:pickerView titleForRow:row forComponent:component];
Expand Down