Jq/build updates #114
Merged
Jq/build updates #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyletsang
approved these changes
Jan 9, 2025
Collaborator
kyletsang
left a comment
kyletsang
left a comment
There was a problem hiding this comment.
Looks good. Should we drop React 16+17 and make this the next major?
Member
Author
|
I am happy to do that, are we ok bumping RB as well? It does seem safer that way |
Collaborator
|
Yep that works. I was thinking of starting the next major version of RB too. I do want to clean up/simplify some stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the build and replaces a bunch of tooling and config with inlined stuff so that it's easier to update later. I went with as simple a config as i could.
Also updates the build to rely solely on
exportsinstead of the cherry picked directories, I think that's ok node have supported this for years and bundlers about as long.still gotta test a bit and some day i'll have to figure out how to update these doc sites build on projects i've abandoned 😬