enhance: MemoCache.query returns {data, paths} just like denormalize#3372
Merged
enhance: MemoCache.query returns {data, paths} just like denormalize#3372
Conversation
🦋 Changeset detectedLatest commit: d0cf69f The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: d0cf69f | Previous: 66e1906 | Ratio |
|---|---|---|---|
normalizeLong |
511 ops/sec (±1.30%) |
521 ops/sec (±0.20%) |
1.02 |
infer All |
9369 ops/sec (±1.58%) |
9493 ops/sec (±0.83%) |
1.01 |
denormalizeLong |
274 ops/sec (±3.23%) |
279 ops/sec (±2.90%) |
1.02 |
denormalizeLong donotcache |
992 ops/sec (±0.46%) |
1020 ops/sec (±0.32%) |
1.03 |
denormalizeShort donotcache 500x |
1405 ops/sec (±0.57%) |
1418 ops/sec (±0.29%) |
1.01 |
denormalizeShort 500x |
797 ops/sec (±1.95%) |
781 ops/sec (±1.90%) |
0.98 |
denormalizeShort 500x withCache |
5239 ops/sec (±0.27%) |
5444 ops/sec (±0.32%) |
1.04 |
queryShort 500x withCache |
2457 ops/sec (±0.59%) |
2421 ops/sec (±0.42%) |
0.99 |
denormalizeLong with mixin Entity |
267 ops/sec (±2.01%) |
259 ops/sec (±2.51%) |
0.97 |
denormalizeLong withCache |
6699 ops/sec (±1.63%) |
6592 ops/sec (±0.28%) |
0.98 |
denormalizeLong All withCache |
8216 ops/sec (±0.30%) |
8029 ops/sec (±0.22%) |
0.98 |
denormalizeLong Query-sorted withCache |
7599 ops/sec (±1.02%) |
7691 ops/sec (±0.62%) |
1.01 |
denormalizeLongAndShort withEntityCacheOnly |
1705 ops/sec (±0.61%) |
1713 ops/sec (±0.28%) |
1.00 |
getResponse |
6140 ops/sec (±1.48%) |
6228 ops/sec (±1.14%) |
1.01 |
getResponse (null) |
5726147 ops/sec (±0.67%) |
5809261 ops/sec (±0.59%) |
1.01 |
getResponse (clear cache) |
269 ops/sec (±1.79%) |
269 ops/sec (±1.80%) |
1 |
getSmallResponse |
2682 ops/sec (±0.16%) |
2653 ops/sec (±0.32%) |
0.99 |
getSmallInferredResponse |
2049 ops/sec (±1.20%) |
2098 ops/sec (±0.16%) |
1.02 |
getResponse Collection |
6410 ops/sec (±1.09%) |
6769 ops/sec (±0.94%) |
1.06 |
get Collection |
6102 ops/sec (±0.46%) |
6152 ops/sec (±0.47%) |
1.01 |
get Query-sorted |
6592 ops/sec (±2.28%) |
6686 ops/sec (±0.28%) |
1.01 |
setLong |
518 ops/sec (±0.26%) |
524 ops/sec (±0.31%) |
1.01 |
setLongWithMerge |
231 ops/sec (±0.27%) |
229 ops/sec (±0.38%) |
0.99 |
setLongWithSimpleMerge |
245 ops/sec (±0.55%) |
243 ops/sec (±0.40%) |
0.99 |
setSmallResponse 500x |
919 ops/sec (±0.33%) |
918 ops/sec (±0.18%) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
5184d51 to
af372b4
Compare
3cb6174 to
d085b5e
Compare
Contributor
|
Size Change: 0 B Total Size: 77.8 kB ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3372 +/- ##
==========================================
- Coverage 98.79% 98.74% -0.05%
==========================================
Files 125 125
Lines 2241 2238 -3
Branches 459 458 -1
==========================================
- Hits 2214 2210 -4
Misses 13 13
- Partials 14 15 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
{data, paths}like memo.denormalize()datacould be INVALIDMotivation
Consistent function signatures; Simpler controller.getQueryMeta() implementation.
Solution
MemoCache.query returns
{ data, paths }just like denormalize.datacould be INVALIDBefore
After