Skip to content

Conversation

@ntucker
Copy link
Collaborator

@ntucker ntucker commented Feb 27, 2025

Motivation

In 165afed#diff-9a40c6a3ef28df92dce0c4b8ab76fd7a4912103d2e767254ed4d93100e532bb0 we tried focusing on bundling polyfills as a robust approach.

Unfortunately, the current way polyfill packages work even including just one polyfill for Object.hasOwn includes around 40 other polyfills that are not needed; increasing all bundle sizes by 30%.

Solution

Go back to the old approach of using @babel/runtime only

@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: b18ca37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@data-client/use-enhanced-reducer Patch
@data-client/normalizr Patch
@data-client/endpoint Patch
@data-client/graphql Patch
@data-client/react Patch
@data-client/core Patch
@data-client/rest Patch
@data-client/test Patch
@data-client/img Patch
example-benchmark Patch
normalizr-github-example Patch
normalizr-redux-example Patch
normalizr-relationships Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025

Size Change: -3.23 kB (-4.04%)

Total Size: 76.7 kB

Filename Size Change
examples/test-bundlesize/dist/App.js 3.41 kB -17 B (-0.5%)
examples/test-bundlesize/dist/polyfill.js 311 B -3.09 kB (-90.86%) 🏆
examples/test-bundlesize/dist/rdc.js 15 kB -34 B (-0.23%)
examples/test-bundlesize/dist/react.js 57.3 kB -18 B (-0.03%)
examples/test-bundlesize/dist/webpack-runtime.js 726 B -72 B (-9.02%)

compressed-size-action

@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (af372b4) to head (b18ca37).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3384   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         136      136           
  Lines        2381     2385    +4     
  Branches      488      490    +2     
=======================================
+ Hits         2351     2355    +4     
  Misses         16       16           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ntucker ntucker force-pushed the master branch 3 times, most recently from 5184d51 to af372b4 Compare February 27, 2025 11:36
@ntucker ntucker merged commit 24ad679 into master Feb 27, 2025
21 checks passed
@ntucker ntucker deleted the manual-polyfill branch February 27, 2025 14:43
@github-actions github-actions bot mentioned this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants