Skip to content

Conversation

@ntucker
Copy link
Collaborator

@ntucker ntucker commented Mar 11, 2025

Motivation

Better naming. Normalizr is the concept of the whole package. normalize and denormalize are the concepts for the two phases that implement it.

Solution

Directory rename: normalizr -> normalize

No functional changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2025

⚠️ No Changeset found

Latest commit: a6b56cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Size Change: -4 B (-0.01%)

Total Size: 76.8 kB

ℹ️ View Unchanged
Filename Size Change
examples/test-bundlesize/dist/App.js 3.41 kB 0 B
examples/test-bundlesize/dist/polyfill.js 311 B 0 B
examples/test-bundlesize/dist/rdc.js 15.1 kB -4 B (-0.03%)
examples/test-bundlesize/dist/react.js 57.3 kB 0 B
examples/test-bundlesize/dist/webpack-runtime.js 726 B 0 B

compressed-size-action

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: a6b56cd Previous: d84899d Ratio
normalizeLong 519 ops/sec (±0.72%) 531 ops/sec (±0.31%) 1.02
infer All 8856 ops/sec (±1.22%) 8892 ops/sec (±0.66%) 1.00
denormalizeLong 256 ops/sec (±2.74%) 248 ops/sec (±3.53%) 0.97
denormalizeLong donotcache 890 ops/sec (±0.67%) 861 ops/sec (±0.41%) 0.97
denormalizeShort donotcache 500x 1412 ops/sec (±0.81%) 1406 ops/sec (±0.39%) 1.00
denormalizeShort 500x 782 ops/sec (±1.94%) 780 ops/sec (±2.11%) 1.00
denormalizeShort 500x withCache 5602 ops/sec (±0.32%) 5657 ops/sec (±0.67%) 1.01
denormalizeLong with mixin Entity 259 ops/sec (±2.04%) 252 ops/sec (±2.16%) 0.97
denormalizeLong withCache 7505 ops/sec (±0.14%) 7227 ops/sec (±0.20%) 0.96
denormalizeLong All withCache 9095 ops/sec (±0.22%) 7302 ops/sec (±0.15%) 0.80
denormalizeLong Query-sorted withCache 8875 ops/sec (±0.90%) 7150 ops/sec (±0.58%) 0.81
denormalizeLongAndShort withEntityCacheOnly 1696 ops/sec (±0.42%) 1685 ops/sec (±0.49%) 0.99
getResponse 8198 ops/sec (±1.05%) 7825 ops/sec (±1.12%) 0.95
getResponse (null) 4949148 ops/sec (±0.46%) 4452454 ops/sec (±0.48%) 0.90
getResponse (clear cache) 255 ops/sec (±2.17%) 253 ops/sec (±2.21%) 0.99
getSmallResponse 2821 ops/sec (±0.45%) 2721 ops/sec (±0.18%) 0.96
getSmallInferredResponse 2074 ops/sec (±0.75%) 2094 ops/sec (±0.27%) 1.01
getResponse Query-sorted 8122 ops/sec (±0.34%) 7536 ops/sec (±0.92%) 0.93
getResponse Collection 7062 ops/sec (±1.18%) 7432 ops/sec (±1.17%) 1.05
get Collection 6391 ops/sec (±0.44%) 6328 ops/sec (±0.34%) 0.99
setLong 530 ops/sec (±0.45%) 534 ops/sec (±0.30%) 1.01
setLongWithMerge 230 ops/sec (±0.47%) 230 ops/sec (±0.45%) 1
setLongWithSimpleMerge 243 ops/sec (±0.76%) 241 ops/sec (±0.36%) 0.99
setSmallResponse 500x 928 ops/sec (±0.28%) 925 ops/sec (±0.15%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (4193075) to head (a6b56cd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3409   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         136      136           
  Lines        2396     2396           
  Branches      490      490           
=======================================
  Hits         2366     2366           
  Misses         16       16           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ntucker ntucker merged commit 7a7bfc5 into master Mar 11, 2025
22 checks passed
@ntucker ntucker deleted the move-normal branch March 11, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants