-
-
Notifications
You must be signed in to change notification settings - Fork 97
internal: Move normalize files #3409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Size Change: -4 B (-0.01%) Total Size: 76.8 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Details
| Benchmark suite | Current: a6b56cd | Previous: d84899d | Ratio |
|---|---|---|---|
normalizeLong |
519 ops/sec (±0.72%) |
531 ops/sec (±0.31%) |
1.02 |
infer All |
8856 ops/sec (±1.22%) |
8892 ops/sec (±0.66%) |
1.00 |
denormalizeLong |
256 ops/sec (±2.74%) |
248 ops/sec (±3.53%) |
0.97 |
denormalizeLong donotcache |
890 ops/sec (±0.67%) |
861 ops/sec (±0.41%) |
0.97 |
denormalizeShort donotcache 500x |
1412 ops/sec (±0.81%) |
1406 ops/sec (±0.39%) |
1.00 |
denormalizeShort 500x |
782 ops/sec (±1.94%) |
780 ops/sec (±2.11%) |
1.00 |
denormalizeShort 500x withCache |
5602 ops/sec (±0.32%) |
5657 ops/sec (±0.67%) |
1.01 |
denormalizeLong with mixin Entity |
259 ops/sec (±2.04%) |
252 ops/sec (±2.16%) |
0.97 |
denormalizeLong withCache |
7505 ops/sec (±0.14%) |
7227 ops/sec (±0.20%) |
0.96 |
denormalizeLong All withCache |
9095 ops/sec (±0.22%) |
7302 ops/sec (±0.15%) |
0.80 |
denormalizeLong Query-sorted withCache |
8875 ops/sec (±0.90%) |
7150 ops/sec (±0.58%) |
0.81 |
denormalizeLongAndShort withEntityCacheOnly |
1696 ops/sec (±0.42%) |
1685 ops/sec (±0.49%) |
0.99 |
getResponse |
8198 ops/sec (±1.05%) |
7825 ops/sec (±1.12%) |
0.95 |
getResponse (null) |
4949148 ops/sec (±0.46%) |
4452454 ops/sec (±0.48%) |
0.90 |
getResponse (clear cache) |
255 ops/sec (±2.17%) |
253 ops/sec (±2.21%) |
0.99 |
getSmallResponse |
2821 ops/sec (±0.45%) |
2721 ops/sec (±0.18%) |
0.96 |
getSmallInferredResponse |
2074 ops/sec (±0.75%) |
2094 ops/sec (±0.27%) |
1.01 |
getResponse Query-sorted |
8122 ops/sec (±0.34%) |
7536 ops/sec (±0.92%) |
0.93 |
getResponse Collection |
7062 ops/sec (±1.18%) |
7432 ops/sec (±1.17%) |
1.05 |
get Collection |
6391 ops/sec (±0.44%) |
6328 ops/sec (±0.34%) |
0.99 |
setLong |
530 ops/sec (±0.45%) |
534 ops/sec (±0.30%) |
1.01 |
setLongWithMerge |
230 ops/sec (±0.47%) |
230 ops/sec (±0.45%) |
1 |
setLongWithSimpleMerge |
243 ops/sec (±0.76%) |
241 ops/sec (±0.36%) |
0.99 |
setSmallResponse 500x |
928 ops/sec (±0.28%) |
925 ops/sec (±0.15%) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3409 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 136 136
Lines 2396 2396
Branches 490 490
=======================================
Hits 2366 2366
Misses 16 16
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Motivation
Better naming. Normalizr is the concept of the whole package. normalize and denormalize are the concepts for the two phases that implement it.
Solution
Directory rename: normalizr -> normalize
No functional changes.