Skip to content

enhance: Make 'symbol' return types more specific (INVALID)#3462

Merged
ntucker merged 1 commit intomasterfrom
invalid-check
Apr 8, 2025
Merged

enhance: Make 'symbol' return types more specific (INVALID)#3462
ntucker merged 1 commit intomasterfrom
invalid-check

Conversation

@ntucker
Copy link
Collaborator

@ntucker ntucker commented Apr 8, 2025

Motivation

Solution

Open questions

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Size Change: 0 B

Total Size: 77.8 kB

ℹ️ View Unchanged
Filename Size
examples/test-bundlesize/dist/App.js 3.42 kB
examples/test-bundlesize/dist/polyfill.js 311 B
examples/test-bundlesize/dist/rdcClient.js 10.2 kB
examples/test-bundlesize/dist/rdcEndpoint.js 5.6 kB
examples/test-bundlesize/dist/react.js 57.5 kB
examples/test-bundlesize/dist/webpack-runtime.js 726 B

compressed-size-action

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: 553a9a2 Previous: 939a4b0 Ratio
normalizeLong 503 ops/sec (±1.14%) 513 ops/sec (±0.39%) 1.02
infer All 9188 ops/sec (±1.53%) 9247 ops/sec (±1.25%) 1.01
denormalizeLong 281 ops/sec (±2.36%) 270 ops/sec (±2.89%) 0.96
denormalizeLong donotcache 1001 ops/sec (±0.30%) 992 ops/sec (±0.57%) 0.99
denormalizeShort donotcache 500x 1409 ops/sec (±0.22%) 1378 ops/sec (±0.22%) 0.98
denormalizeShort 500x 790 ops/sec (±2.00%) 760 ops/sec (±3.07%) 0.96
denormalizeShort 500x withCache 5250 ops/sec (±0.32%) 5137 ops/sec (±0.25%) 0.98
queryShort 500x withCache 2420 ops/sec (±0.28%) 2400 ops/sec (±0.32%) 0.99
denormalizeLong with mixin Entity 258 ops/sec (±1.98%) 261 ops/sec (±1.85%) 1.01
denormalizeLong withCache 7047 ops/sec (±0.27%) 6971 ops/sec (±0.26%) 0.99
denormalizeLong All withCache 8365 ops/sec (±0.17%) 6935 ops/sec (±0.20%) 0.83
denormalizeLong Query-sorted withCache 7796 ops/sec (±0.92%) 6560 ops/sec (±0.80%) 0.84
denormalizeLongAndShort withEntityCacheOnly 1704 ops/sec (±0.38%) 1717 ops/sec (±0.38%) 1.01
getResponse 6557 ops/sec (±1.25%) 6679 ops/sec (±1.11%) 1.02
getResponse (null) 6085442 ops/sec (±0.68%) 5463884 ops/sec (±0.61%) 0.90
getResponse (clear cache) 258 ops/sec (±2.06%) 262 ops/sec (±1.89%) 1.02
getSmallResponse 2680 ops/sec (±0.12%) 2643 ops/sec (±0.25%) 0.99
getSmallInferredResponse 2032 ops/sec (±0.60%) 2056 ops/sec (±0.11%) 1.01
getResponse Collection 6438 ops/sec (±1.03%) 6540 ops/sec (±1.30%) 1.02
get Collection 5876 ops/sec (±0.46%) 6019 ops/sec (±0.47%) 1.02
get Query-sorted 7267 ops/sec (±0.21%) 7361 ops/sec (±0.27%) 1.01
setLong 512 ops/sec (±0.61%) 514 ops/sec (±0.31%) 1.00
setLongWithMerge 227 ops/sec (±0.28%) 228 ops/sec (±0.38%) 1.00
setLongWithSimpleMerge 239 ops/sec (±0.34%) 241 ops/sec (±0.30%) 1.01
setSmallResponse 500x 915 ops/sec (±0.25%) 917 ops/sec (±0.29%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (ec5cfb3) to head (553a9a2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3462   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         124      124           
  Lines        2239     2239           
  Branches      460      460           
=======================================
  Hits         2211     2211           
  Misses         13       13           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2025

⚠️ No Changeset found

Latest commit: 553a9a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ntucker ntucker marked this pull request as ready for review April 8, 2025 18:03
@ntucker ntucker changed the title enhance: Perform INVALID checks against the symbol itself enhance: Make 'symbol' return types more specific (INVALID) Apr 8, 2025
@ntucker ntucker merged commit 422120f into master Apr 8, 2025
24 checks passed
@ntucker ntucker deleted the invalid-check branch April 8, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant