fix: export types needed for EntityMixin#3480
Merged
ntucker merged 1 commit intoreactive:masterfrom Apr 30, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 152d736 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3480 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 124 124
Lines 2239 2239
Branches 460 460
=======================================
Hits 2211 2211
Misses 13 13
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ntucker
approved these changes
Apr 30, 2025
Merged
ntucker
pushed a commit
that referenced
this pull request
May 1, 2025
ntucker
pushed a commit
that referenced
this pull request
May 1, 2025
Collaborator
|
Thanks @Tomaszal for this PR; just released a new version of @data-client/endpoint with the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following TypeScript error when using
EntityMixin:The inferred type of ... cannot be named without a reference to '../../node_modules/@data-client/endpoint/lib/schemas/EntityTypes'. This is likely not portable. A type annotation is necessary.ts(2742)