Conversation
🦋 Changeset detectedLatest commit: afa6b9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
26b6665 to
5923aea
Compare
Contributor
|
Size Change: +21 B (+0.03%) Total Size: 77.7 kB
ℹ️ View Unchanged
|
5923aea to
afa6b9d
Compare
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: afa6b9d | Previous: fcb7d7d | Ratio |
|---|---|---|---|
normalizeLong |
517 ops/sec (±1.03%) |
534 ops/sec (±1.55%) |
1.03 |
denormalizeLong |
294 ops/sec (±2.23%) |
280 ops/sec (±3.25%) |
0.95 |
denormalizeLong donotcache |
1042 ops/sec (±0.28%) |
1024 ops/sec (±1.00%) |
0.98 |
denormalizeShort donotcache 500x |
1616 ops/sec (±0.11%) |
1618 ops/sec (±0.09%) |
1.00 |
denormalizeShort 500x |
867 ops/sec (±1.88%) |
846 ops/sec (±1.78%) |
0.98 |
denormalizeShort 500x withCache |
6611 ops/sec (±0.12%) |
6722 ops/sec (±0.12%) |
1.02 |
queryShort 500x withCache |
2796 ops/sec (±0.09%) |
2682 ops/sec (±0.08%) |
0.96 |
buildQueryKey All |
55501 ops/sec (±0.65%) |
55354 ops/sec (±0.38%) |
1.00 |
query All withCache |
6662 ops/sec (±0.21%) |
7343 ops/sec (±0.32%) |
1.10 |
denormalizeLong with mixin Entity |
274 ops/sec (±2.33%) |
276 ops/sec (±2.37%) |
1.01 |
denormalizeLong withCache |
6484 ops/sec (±0.21%) |
6797 ops/sec (±0.22%) |
1.05 |
denormalizeLong All withCache |
6441 ops/sec (±0.38%) |
7209 ops/sec (±0.15%) |
1.12 |
denormalizeLong Query-sorted withCache |
6698 ops/sec (±0.17%) |
7446 ops/sec (±1.13%) |
1.11 |
denormalizeLongAndShort withEntityCacheOnly |
1727 ops/sec (±0.24%) |
1707 ops/sec (±0.18%) |
0.99 |
getResponse |
5603 ops/sec (±1.28%) |
5647 ops/sec (±1.42%) |
1.01 |
getResponse (null) |
6675063 ops/sec (±0.49%) |
6765613 ops/sec (±0.65%) |
1.01 |
getResponse (clear cache) |
279 ops/sec (±2.12%) |
273 ops/sec (±1.87%) |
0.98 |
getSmallResponse |
3100 ops/sec (±0.10%) |
3076 ops/sec (±0.12%) |
0.99 |
getSmallInferredResponse |
2314 ops/sec (±0.40%) |
2304 ops/sec (±0.12%) |
1.00 |
getResponse Collection |
5511 ops/sec (±1.02%) |
5560 ops/sec (±1.11%) |
1.01 |
get Collection |
5526 ops/sec (±0.30%) |
5651 ops/sec (±0.26%) |
1.02 |
get Query-sorted |
6409 ops/sec (±0.72%) |
6771 ops/sec (±0.21%) |
1.06 |
setLong |
527 ops/sec (±0.26%) |
553 ops/sec (±0.17%) |
1.05 |
setLongWithMerge |
244 ops/sec (±0.20%) |
243 ops/sec (±0.64%) |
1.00 |
setLongWithSimpleMerge |
252 ops/sec (±0.42%) |
261 ops/sec (±0.09%) |
1.04 |
setSmallResponse 500x |
947 ops/sec (±0.09%) |
944 ops/sec (±0.08%) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3560 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 130 130
Lines 2249 2252 +3
Branches 453 453
=======================================
+ Hits 2210 2213 +3
Misses 10 10
Partials 29 29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Invalidate() removes everywhere, but what if we want to just remove from one collection and keep in others?
https://backbonejs.org/#Collection-remove
Solution
or
Open questions