fix: Collection.remove

[ntucker]

Motivation

Remove merge logic assumed a raw entity (normalize to string) vs union ({ id, schema })

Solution

Add pkEqual() to do comparison that handles both cases. Add more tests for Union Collections

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2bb9f05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

Size Change: +39 B (+0.05%)

Total Size: 77.8 kB

Filename	Size	Change
examples/test-bundlesize/dist/rdcEndpoint.js	5.68 kB	+39 B (+0.69%)

ℹ️ View Unchanged

Filename	Size
examples/test-bundlesize/dist/App.js	3.42 kB
examples/test-bundlesize/dist/polyfill.js	311 B
examples/test-bundlesize/dist/rdcClient.js	10.1 kB
examples/test-bundlesize/dist/react.js	57.5 kB
examples/test-bundlesize/dist/webpack-runtime.js	726 B

_{compressed-size-action}

[github-actions]

Benchmark

Details

Benchmark suite	Current: 2bb9f05	Previous: 531f53d	Ratio
normalizeLong	538 ops/sec (±0.97%)	529 ops/sec (±1.12%)	0.98
denormalizeLong	274 ops/sec (±2.45%)	298 ops/sec (±2.02%)	1.09
denormalizeLong donotcache	1040 ops/sec (±1.24%)	1022 ops/sec (±1.71%)	0.98
denormalizeShort donotcache 500x	1598 ops/sec (±0.16%)	1631 ops/sec (±0.19%)	1.02
denormalizeShort 500x	845 ops/sec (±1.73%)	847 ops/sec (±1.70%)	1.00
denormalizeShort 500x withCache	6234 ops/sec (±0.18%)	6543 ops/sec (±0.16%)	1.05
queryShort 500x withCache	2765 ops/sec (±0.34%)	2853 ops/sec (±0.15%)	1.03
buildQueryKey All	53690 ops/sec (±0.16%)	54774 ops/sec (±0.22%)	1.02
query All withCache	7262 ops/sec (±0.56%)	6836 ops/sec (±0.17%)	0.94
denormalizeLong with mixin Entity	273 ops/sec (±2.22%)	284 ops/sec (±1.99%)	1.04
denormalizeLong withCache	6338 ops/sec (±0.22%)	7253 ops/sec (±0.16%)	1.14
denormalizeLong All withCache	6894 ops/sec (±0.19%)	6549 ops/sec (±0.10%)	0.95
denormalizeLong Query-sorted withCache	7329 ops/sec (±0.14%)	6852 ops/sec (±0.11%)	0.93
denormalizeLongAndShort withEntityCacheOnly	1703 ops/sec (±0.26%)	1805 ops/sec (±0.20%)	1.06
getResponse	5699 ops/sec (±1.42%)	5748 ops/sec (±1.50%)	1.01
getResponse (null)	7155801 ops/sec (±0.72%)	7459760 ops/sec (±0.99%)	1.04
getResponse (clear cache)	273 ops/sec (±2.17%)	284 ops/sec (±1.94%)	1.04
getSmallResponse	3052 ops/sec (±0.19%)	3126 ops/sec (±0.16%)	1.02
getSmallInferredResponse	2333 ops/sec (±0.13%)	2336 ops/sec (±0.15%)	1.00
getResponse Collection	5542 ops/sec (±1.33%)	5750 ops/sec (±1.68%)	1.04
get Collection	5964 ops/sec (±0.19%)	5832 ops/sec (±0.29%)	0.98
get Query-sorted	6737 ops/sec (±0.54%)	6730 ops/sec (±0.36%)	1.00
setLong	544 ops/sec (±0.23%)	539 ops/sec (±0.60%)	0.99
setLongWithMerge	245 ops/sec (±0.12%)	246 ops/sec (±0.15%)	1.00
setLongWithSimpleMerge	261 ops/sec (±0.20%)	261 ops/sec (±0.17%)	1
setSmallResponse 500x	943 ops/sec (±0.08%)	944 ops/sec (±0.07%)	1.00

This comment was automatically generated by workflow using github-action-benchmark.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.27%. Comparing base (92bd01c) to head (2bb9f05).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3564   +/-   ##
=======================================
  Coverage   98.26%   98.27%           
=======================================
  Files         130      130           
  Lines        2252     2258    +6     
  Branches      453      455    +2     
=======================================
+ Hits         2213     2219    +6     
  Misses         10       10           
  Partials       29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.