chore: Move the tests into one file for ReactiveExtensions.cs#101
chore: Move the tests into one file for ReactiveExtensions.cs#101glennawatson merged 8 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates test files by moving all tests from ComprehensiveReactiveExtensionsTests.cs into the existing ReactiveExtensionsTests.cs file, then removing the former. This improves test organization by keeping all tests for ReactiveExtensions in a single location.
- Moved 1,719 lines of test code from ComprehensiveReactiveExtensionsTests.cs to ReactiveExtensionsTests.cs
- Deleted ComprehensiveReactiveExtensionsTests.cs file completely
- All test methods retain their original implementation and documentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 57 comments.
| File | Description |
|---|---|
| src/ReactiveUI.Extensions.Tests/ReactiveExtensionsTests.cs | Added comprehensive test methods from ComprehensiveReactiveExtensionsTests.cs, covering BufferUntil, CatchIgnore, CombineLatest, GetMax/GetMin, DetectStale, Conflate, Heartbeat, WithLimitedConcurrency, OnNext, ObserveOnSafe, scheduling, filtering, retry logic, synchronization, and various other ReactiveExtensions operators. Minor indentation issue detected on line 235. |
| src/ReactiveUI.Extensions.Tests/ComprehensiveReactiveExtensionsTests.cs | Removed entire file containing 1,739 lines of test code that was moved to ReactiveExtensionsTests.cs |
| [Test] | ||
| public void CombineLatestValuesAreAllFalse_WhenAllFalse_ReturnsTrue() | ||
| { | ||
| var subject1 = new BehaviorSubject<bool>(false); |
There was a problem hiding this comment.
Disposable 'BehaviorSubject' is created but not disposed.
| public void BufferUntilInactive_BuffersValuesUntilInactivity() | ||
| { | ||
| var scheduler = new TestScheduler(); | ||
| var subject = new Subject<int>(); |
There was a problem hiding this comment.
Disposable 'Subject' is created but not disposed.
| var subject = new Subject<int>(); | |
| using var subject = new Subject<int>(); |
| { | ||
| var executed = false; | ||
| IScheduler? scheduler = null; | ||
| var disposable = scheduler.ScheduleSafe(() => executed = true); |
* Initial plan * Add missing using statements to fix compilation errors Co-authored-by: glennawatson <5834289+glennawatson@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: glennawatson <5834289+glennawatson@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
=======================================
Coverage 80.33% 80.33%
=======================================
Files 8 8
Lines 651 651
Branches 64 64
=======================================
Hits 523 523
Misses 104 104
Partials 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR consolidates test files by moving all tests from ComprehensiveReactiveExtensionsTests.cs into the existing ReactiveExtensionsTests.cs file, then removing the former. This improves test organization by keeping all tests for ReactiveExtensions in a single location.